biemond/biemond-wildfly

View on GitHub
spec/defines/reload_spec.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

describe 'wildfly::reload' do
  let(:facts) do
    { :operatingsystem => 'CentOS',
      :kernel => 'Linux',
      :osfamily => 'RedHat',
Severity: Major
Found in spec/defines/reload_spec.rb and 2 other locations - About 1 hr to fix
spec/defines/cli_spec.rb on lines 3..49
spec/defines/resource_spec.rb on lines 3..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Example has too many lines [6/5].
Open

    it do
      is_expected.to contain_wildfly_restart(title)
        .with(:username => 'admin',
              :password => 'safepassword',
              :host     => '192.168.10.10',
Severity: Minor
Found in spec/defines/reload_spec.rb by rubocop

Use meaningful heredoc delimiters.
Open

    EOS
Severity: Minor
Found in spec/defines/reload_spec.rb by rubocop

This cop checks that your heredocs are using meaningful delimiters. By default it disallows END and EO*, and can be configured through blacklisting additional delimiters.

Example:

# good
<<-SQL
  SELECT * FROM foo
SQL

# bad
<<-END
  SELECT * FROM foo
END

# bad
<<-EOS
  SELECT * FROM foo
EOS

The first argument to describe should be the class or module being tested.
Open

describe 'wildfly::reload' do
Severity: Minor
Found in spec/defines/reload_spec.rb by rubocop

There are no issues that match your filters.

Category
Status