birm/MiniMat

View on GitHub

Showing 9 of 9 total issues

MiniMat has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class MiniMat {
    constructor(data, x_len, y_len=1) {
        // validate the input
        // define an inline function to pass to Array.proto.every
        function isNumberType(element, index, array) {
Severity: Minor
Found in MiniMat.js - About 3 hrs to fix

    File MiniMat.js has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     *  @fileoverview Matrix algebra library for javascript.
     *  @author birm@rbirm.us (Ryan Birmingham)
     *  @license Copyright 2017 Ryan Birmingham.
     *  Licensed under GPL-3.
    Severity: Minor
    Found in MiniMat.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          t.equal( MiniMat.FilledMat(3, 2, 4).product(MiniMat.FilledMat(2, 3, 4)).toString(true), MiniMat.FilledMat(2, 2, 32).toString(true), "Test matrix schur product");
      Severity: Major
      Found in tests.js and 1 other location - About 1 hr to fix
      tests.js on lines 65..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          t.equal( MiniMat.FilledMat(3, 2, 4).schur(MiniMat.FilledMat(3, 2, 4)).toString(true), MiniMat.FilledMat(3, 2, 16).toString(true), "Test matrix schur product");
      Severity: Major
      Found in tests.js and 1 other location - About 1 hr to fix
      tests.js on lines 71..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function OnLoad has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static OnLoad(file_tag='fileInput', x_tag='x_len', y_tag='y_len', preview_tag='preview'){
            var fileInput = document.getElementById(file_tag);
            var fileDisplayArea = document.getElementById(preview_tag);
      
            fileInput.addEventListener('change', function(e) {
      Severity: Minor
      Found in MiniMat.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            * cols(){
              var ind = 0;
              while (ind < this.y_len){
                yield this.col(ind);
                ind ++;
        Severity: Minor
        Found in MiniMat.js and 1 other location - About 50 mins to fix
        MiniMat.js on lines 95..101

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            * rows(){
              var ind = 0;
              while (ind < this.y_len){
                yield this.row(ind);
                ind ++;
        Severity: Minor
        Found in MiniMat.js and 1 other location - About 50 mins to fix
        MiniMat.js on lines 162..168

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function product has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            product(mat){
              // make sure they're compatible
              if (!(this.y_len === mat.x_len)){
                throw new Error("[Data Error] Matrices must share inner dimension size.");
              }
        Severity: Minor
        Found in MiniMat.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function normalize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            normalize(rowvecs=false){
                // run with false for column vectors, true for row vectors
                var x_len = parseFloat(this.x_len);
                var y_len = parseFloat(this.y_len);
                var itlen;
        Severity: Minor
        Found in MiniMat.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language