bisscomm/refinerycms-products

View on GitHub

Showing 3 of 3 total issues

Method nested_li has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def nested_li(objects, &block)
        objects = objects.order(:lft) if objects.is_a? Class

        return '' if objects.size == 0

Severity: Minor
Found in app/helpers/refinery/products/products_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def update
          if @category.update_attributes(category_params)
            flash.notice = t('refinery.crudify.updated', what: "'#{@category.title}'")

            if from_dialog?
Severity: Minor
Found in app/controllers/refinery/products/admin/categories_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def update
          if @category.update_attributes(category_params)
            flash.notice = t('refinery.crudify.updated', what: "'#{@category.title}'")

            if from_dialog?
Severity: Minor
Found in app/controllers/refinery/products/admin/categories_controller.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language