bitslip6/bitfire

View on GitHub

Showing 749 of 749 total issues

Reference to undeclared property \BitFireSvr\FileHash->plugin_id
Open

                $known = intval($check_file->plugin_id) > 0 && $check_file["r"] != "MISS";
Severity: Minor
Found in firewall/src/cms.php by phan

Argument 1 (pattern) is true but \preg_match() takes string
Open

            if (preg_match($config->extra_regex, $c3, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER)) {
Severity: Minor
Found in firewall/src/cms.php by phan

Possibly zero references to use statement for constant ThreadFinCUCKOO_LOW (\ThreadFin\CUCKOO_LOW)
Open

use const ThreadFin\CUCKOO_LOW as ThreadFinCUCKOO_LOW;
Severity: Minor
Found in firewall/src/cuckoo.php by phan

Returning type ?bool but cuckoo_find_header_for_read() is declared to return ?array
Open

            return debugN("cache keys miss-match [%s] 1:%d/%d, 2:%d/%d", $key, $key_hashes[0], $header['hash1'], $key_hashes[1], $header['hash2']);
Severity: Minor
Found in firewall/src/cuckoo.php by phan

Suspicious array access to nullable ?array
Open

        ($header['hash1'] === $key_hashes[0] && $header['hash2'] === $key_hashes[1]) ||
Severity: Minor
Found in firewall/src/cuckoo.php by phan

Call with 2 arg(s) to \ThreadFin\Effect::chain() which only takes 1 arg(s) defined at /code/firewall/src/util.php:938
Open

    $e->chain(update_ini_value("secret", random_str(32)), "default");
Severity: Info
Found in firewall/src/server.php by phan

Call to undeclared function \content_url()
Open

            $content_url = \content_url();
Severity: Critical
Found in firewall/src/server.php by phan

Possibly zero references to use statement for constant WAF_SRC (\BitFire\WAF_SRC)
Open

use const BitFire\WAF_SRC;
Severity: Minor
Found in firewall/src/botfilter.php by phan

Doc-block of get_plugin_file_info contains declared return type array which is incompatible with the return type void declared in the signature
Open

 * @return array 
Severity: Minor
Found in firewall/src/cms.php by phan

Doc-block of cms_find_malware contains declared return type array which is incompatible with the return type \BitFire\Malware_List declared in the signature
Open

 * @return array 
Severity: Minor
Found in firewall/src/cms.php by phan

Argument 2 (per_unknown) is int but \BitFire\malware_creator() takes string defined at /code/firewall/src/cms.php:891
Open

    $malware_factory = malware_creator($file_name, $not_found_per, $php_count, $frequency->frequency, $max_len, $size, $known);
Severity: Minor
Found in firewall/src/cms.php by phan

Suspicious array access to nullable ?array
Open

        return debugN("cache entry expired [%s] %d/%d", $key, $header['expires'], $ctx['now']);
Severity: Minor
Found in firewall/src/cuckoo.php by phan

Method \ThreadFinDB\Credentials::__construct is declared to return \ThreadFinDB\Credentials but has no return value
Open

    public function __construct(string $user, string $pass, string $host, string $db_name, string $pre = "") {
Severity: Minor
Found in firewall/src/db.php by phan

Argument 2 (arr2) is ?array but \array_diff_key() takes array
Open

            $update_data = array_diff_key($data, $no_update);
Severity: Minor
Found in firewall/src/db.php by phan

Reference to undeclared constant \MYSQLI_NUM
Open

        $rows = $db->fetch("SELECT * FROM $table LIMIT $limit OFFSET $idx", NULL, MYSQLI_NUM);
Severity: Minor
Found in firewall/src/db.php by phan

Variable $edits was undeclared, but array fields are being added to it.
Open

            $edits[] = new FineDiffDeleteOp($from_len);
Severity: Info
Found in firewall/src/diff.php by phan

Call to undeclared function \BitFirePRO\send_pro_headers()
Open

        $effect->chain(\BitFirePRO\send_pro_headers($request, $cookies, $agent));
Severity: Critical
Found in firewall/src/headers.php by phan

Call with 2 arg(s) to \ThreadFin\Effect::chain() which only takes 1 arg(s) defined at /code/firewall/src/util.php:938
Open

    $e->chain(update_ini_value("browser_cookie", "_" . random_str(4)), "_bitfire");
Severity: Info
Found in firewall/src/server.php by phan

Possibly zero references to use statement for classlike/namespace Block (\BitFire\Block)
Open

use \BitFire\Block as Block;
Severity: Minor
Found in firewall/src/util.php by phan

array to string conversion
Open

function dbg($x, $msg="") {$m=htmlspecialchars($msg); $z=(php_sapi_name() == "cli") ? print_r($x, true) : htmlspecialchars(print_r($x, true)); echo "<pre>\n[$m]\n($z)\n" . join("\n", debug(null)) . "\n" . debug(trace(null));
Severity: Info
Found in firewall/src/util.php by phan
Severity
Category
Status
Source
Language