bizley/yii2-podium

View on GitHub

Showing 223 of 419 total issues

Avoid too many return statements within this method.
Open

            return $this->redirect(['forum/maintenance']);
Severity: Major
Found in src/controllers/BaseController.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                            return $this->redirect(['forum/show', 'id' => $model->id]);
    Severity: Major
    Found in src/controllers/ForumPostController.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return Html::tag('span',
                      Html::tag('span', '', ['class' => 'glyphicon glyphicon-ok-circle'])
                      . ' ' . Yii::t('podium/view', "New forums' order has been saved."),
                      ['class' => 'text-success']
                  );
      Severity: Major
      Found in src/controllers/AdminForumController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return $this->redirect([
                                'forum/thread',
                                'cid' => $post->forum->category->id,
                                'fid' => $post->forum->id,
                                'id' => $post->thread->id,
        Severity: Major
        Found in src/controllers/ForumPostController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this->render('edit', [
                      'preview' => $preview,
                      'model' => $post,
                      'isFirstPost' => $isFirstPost
                  ]);
          Severity: Major
          Found in src/controllers/ForumPostController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $this->returnError($e->getMessage(), __METHOD__,
                            Yii::t('podium/flash', 'Error during table foreign key {name} adding', [
                                'name' => $this->getForeignName($key)
                            ])
                        );
            Severity: Major
            Found in src/maintenance/SchemaOperation.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $this->render('deleteposts', [
                          'model' => $thread,
                          'dataProvider' => (new Post())->search($thread->forum->id, $thread->id)
                      ]);
              Severity: Major
              Found in src/controllers/ForumPostController.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return Html::tag('span',
                            Html::tag('span', '', ['class' => 'glyphicon glyphicon-warning-sign'])
                            . ' ' . Yii::t('podium/view', "Sorry! We can not save new forums' order."),
                            ['class' => 'text-danger']
                        );
                Severity: Major
                Found in src/controllers/AdminForumController.php - About 30 mins to fix

                  Function actionRun has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionRun($limit = 0)
                      {
                          $version = $this->module->version;
                          $this->stdout("\nPodium mail queue v{$version}\n");
                          $this->stdout("------------------------------\n");
                  Severity: Minor
                  Found in src/console/QueueController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function podiumMarkAllSeen has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function podiumMarkAllSeen()
                      {
                          try {
                              $loggedId = User::loggedId();
                              if (empty($loggedId)) {
                  Severity: Minor
                  Found in src/models/Thread.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function isMessageReceiver has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function isMessageReceiver($userId)
                      {
                          if ($this->messageReceivers) {
                              foreach ($this->messageReceivers as $receiver) {
                                  if ($receiver->receiver_id == $userId) {
                  Severity: Minor
                  Found in src/models/Message.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function demoteTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function demoteTo($role)
                      {
                          $transaction = static::getDb()->beginTransaction();
                          try {
                              $this->scenario = 'role';
                  Severity: Minor
                  Found in src/models/User.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getStored has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getStored()
                      {
                          $stored = [];
                          try {
                              $query = (new Query)->from(static::tableName())->all();
                  Severity: Minor
                  Found in src/PodiumConfig.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionForum has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionForum($cid = null, $id = null, $slug = null, $toggle = null)
                      {
                          $filters = Yii::$app->session->get('forum-filters');
                          if (in_array(strtolower($toggle), ['new', 'edit', 'hot', 'pin', 'lock', 'all'])) {
                              if (strtolower($toggle) == 'all') {
                  Severity: Minor
                  Found in src/controllers/ForumController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function generateUsername has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function generateUsername()
                      {
                          $userNameField = Podium::getInstance()->userNameField;
                          if ($userNameField !== null) {
                              if (empty(Podium::getInstance()->user->identity->$userNameField)) {
                  Severity: Minor
                  Found in src/models/User.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function checkAccess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function checkAccess()
                      {
                          if (YII_ENV === 'test') {
                              return true;
                          }
                  Severity: Minor
                  Found in src/controllers/InstallController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function init()
                      {
                          parent::init();
                  
                          $session = \Yii::$app->getSession();
                  Severity: Minor
                  Found in src/widgets/Alert.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getNamedUsersList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getNamedUsersList($url)
                      {
                          $out = '';
                          $conditions = ['and',
                              [Activity::tableName() . '.anonymous' => 0],
                  Severity: Minor
                  Found in src/widgets/Readers.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionSortForum has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionSortForum()
                      {
                          if (!Yii::$app->request->isAjax) {
                              return $this->redirect(['admin/forums']);
                          }
                  Severity: Minor
                  Found in src/controllers/AdminForumController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function actionSortCategory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function actionSortCategory()
                      {
                          if (!Yii::$app->request->isAjax) {
                              return $this->redirect(['admin/categories']);
                          }
                  Severity: Minor
                  Found in src/controllers/AdminForumController.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language