bizley/yii2-podium

View on GitHub

Showing 223 of 419 total issues

Function podiumNew has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function podiumNew()
    {
        $transaction = static::getDb()->beginTransaction();
        try {
            if (!$this->save()) {
Severity: Minor
Found in src/models/Thread.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method actionDeletepost has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionDeletepost($cid = null, $fid = null, $tid = null, $pid = null)
    {
        $post = Post::verify($cid, $fid, $tid, $pid);
        if (empty($post)) {
            $this->error(Yii::t('podium/flash', 'Sorry! We can not find the post you are looking for.'));
Severity: Minor
Found in src/controllers/ForumPostController.php - About 1 hr to fix

    Method search has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function search($forumId = null, $filters = null)
        {
            $query = static::find();
            if ($forumId) {
                $query->where(['forum_id' => (int)$forumId]);
    Severity: Minor
    Found in src/models/Thread.php - About 1 hr to fix

      Method actionDeleteposts has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function actionDeleteposts($cid = null, $fid = null, $id = null, $slug = null)
          {
              $thread = (new ThreadVerifier([
                  'categoryId' => $cid,
                  'forumId' => $fid,
      Severity: Minor
      Found in src/controllers/ForumPostController.php - About 1 hr to fix

        Method addContent has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function addContent()
            {
                try {
                    $default = Content::defaultContent();
                    $this->db->createCommand()->batchInsert(
        Severity: Minor
        Found in src/maintenance/Installation.php - About 1 hr to fix

          Function search has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function search($forumId = null, $filters = null)
              {
                  $query = static::find();
                  if ($forumId) {
                      $query->where(['forum_id' => (int)$forumId]);
          Severity: Minor
          Found in src/models/Thread.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function remove has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function remove()
              {
                  $transaction = static::getDb()->beginTransaction();
                  try {
                      $clearCache = false;
          Severity: Minor
          Found in src/models/MessageReceiver.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method actionDeletepoll has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function actionDeletepoll($cid = null, $fid = null, $tid = null, $pid = null)
              {
                  $poll = Poll::find()->joinWith('thread')->where([
                      Poll::tableName() . '.id' => $pid,
                      Poll::tableName() . '.thread_id' => $tid,
          Severity: Minor
          Found in src/controllers/ForumController.php - About 1 hr to fix

            Method actionNewThread has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function actionNewThread($cid = null, $fid = null)
                {
                    if (!User::can(Rbac::PERM_CREATE_THREAD)) {
                        $this->error(Yii::t('podium/flash', 'Sorry! You do not have the required permission to perform this action.'));
                        return $this->redirect(['forum/index']);
            Severity: Minor
            Found in src/controllers/ForumThreadController.php - About 1 hr to fix

              Method addInheritedAdmin has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function addInheritedAdmin()
                  {
                      if (empty($this->module->adminId)) {
                          $this->type = self::TYPE_WARNING;
                          return Yii::t('podium/flash', 'No administrator privileges have been set!');
              Severity: Minor
              Found in src/maintenance/Installation.php - About 1 hr to fix

                Method podiumDeletePosts has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function podiumDeletePosts($posts)
                    {
                        $transaction = static::getDb()->beginTransaction();
                        try {
                            foreach ($posts as $post) {
                Severity: Minor
                Found in src/models/Thread.php - About 1 hr to fix

                  Method actionDetails has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function actionDetails()
                      {
                          $model = User::findMe();
                          if (empty($model)) {
                              return $this->redirect(['account/login']);
                  Severity: Minor
                  Found in src/controllers/ProfileController.php - About 1 hr to fix

                    Method podiumMarkAllSeen has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function podiumMarkAllSeen()
                        {
                            try {
                                $loggedId = User::loggedId();
                                if (empty($loggedId)) {
                    Severity: Minor
                    Found in src/models/Thread.php - About 1 hr to fix

                      Method actionReport has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function actionReport($cid = null, $fid = null, $tid = null, $pid = null)
                          {
                              $post = Post::verify($cid, $fid, $tid, $pid);
                              if (empty($post)) {
                                  $this->error(Yii::t('podium/flash', 'Sorry! We can not find the post you are looking for.'));
                      Severity: Minor
                      Found in src/controllers/ForumPostController.php - About 1 hr to fix

                        Method actionSortForum has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function actionSortForum()
                            {
                                if (!Yii::$app->request->isAjax) {
                                    return $this->redirect(['admin/forums']);
                                }
                        Severity: Minor
                        Found in src/controllers/AdminForumController.php - About 1 hr to fix

                          Method actionAdd has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function actionAdd($id = null)
                              {
                                  if (!Yii::$app->request->isAjax) {
                                      return $this->redirect(['forum/index']);
                                  }
                          Severity: Minor
                          Found in src/controllers/ProfileController.php - About 1 hr to fix

                            Method export has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function export()
                                {
                                    $tableName = Podium::getInstance()->db->quoteTableName($this->logTable);
                                    $sql = "INSERT INTO $tableName ([[level]], [[category]], [[log_time]], [[ip]], [[message]], [[model]], [[user]])
                                            VALUES (:level, :category, :log_time, :ip, :message, :model, :user)";
                            Severity: Minor
                            Found in src/log/DbTarget.php - About 1 hr to fix

                              Method remove has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function remove()
                                  {
                                      $transaction = static::getDb()->beginTransaction();
                                      try {
                                          $clearCache = false;
                              Severity: Minor
                              Found in src/models/MessageReceiver.php - About 1 hr to fix

                                Function reformRun has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    protected function reformRun($componentInfo, $model, $log, $view)
                                    {
                                        if ($this->module->userComponent !== true) {
                                            $this->info($componentInfo);
                                            return $this->module->goPodium();
                                Severity: Minor
                                Found in src/controllers/AccountController.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function actionReply has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function actionReply($id = null)
                                    {
                                        $podiumUser = User::findMe();
                                
                                        if (Message::tooMany($podiumUser->id)) {
                                Severity: Minor
                                Found in src/controllers/MessagesController.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language