Sign upLogin

bluetree-service/data

View on GitHub
Star

Showing 6 of 6 total issues

The class Validator has 15 public methods. Consider refactoring Validator to keep number of public methods under 10.
Open

class Validator
{
    public const IBAN_CHARS = [
        '0' => '0', '1' => '1', '2' => '2', '3' => '3', '4' => '4',
        '5' => '5', '6' => '6', '7' => '7', '8' => '8', '9' => '9',
Severity: Minor
Found in src/Check/Validator.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class Validator has an overall complexity of 55 which is very high. The configured complexity threshold is 50.
Open

class Validator
{
    public const IBAN_CHARS = [
        '0' => '0', '1' => '1', '2' => '2', '3' => '3', '4' => '4',
        '5' => '5', '6' => '6', '7' => '7', '8' => '8', '9' => '9',
Severity: Minor
Found in src/Check/Validator.php by phpmd

Validator has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class Validator
{
    public const IBAN_CHARS = [
        '0' => '0', '1' => '1', '2' => '2', '3' => '3', '4' => '4',
        '5' => '5', '6' => '6', '7' => '7', '8' => '8', '9' => '9',
Severity: Minor
Found in src/Check/Validator.php - About 2 hrs to fix

    Function loadAndValid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function loadAndValid(string $path, bool $parse): bool
    {
        $bool = false;
        $additional = '';
    Severity: Minor
    Found in src/Data/Xml.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method loadXmlFile has a boolean flag argument $parse, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function loadXmlFile(string $path, bool $parse = false): bool
    Severity: Minor
    Found in src/Data/Xml.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid unused parameters such as '$xml'.
    Open

        public function __construct($xml)
    Severity: Minor
    Found in src/Data/SimpleXml.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Severity
    Category
    Status
    Source
    Language