Sign upLogin

bnomei/kirby3-feed

View on GitHub
Star
classes/Feed.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method optionsFromDefault has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function optionsFromDefault(?Pages $pages = null, $options = []): array
    {
        $defaults = [
            // json/rss
            'url' => site()->url(),
Severity: Minor
Found in classes/Feed.php - About 1 hr to fix

    Function optionsFromDefault has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function optionsFromDefault(?Pages $pages = null, $options = []): array
    {
        $defaults = [
            // json/rss
            'url' => site()->url(),
    Severity: Minor
    Found in classes/Feed.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return new Response('Error: Feed Response', null, 500);
    Severity: Major
    Found in classes/Feed.php - About 30 mins to fix

      Function response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function response(): Response
    {
        $snippet = A::get($this->options, 'snippet');
        $mime = Mime::fromExtension(A::get($this->options, 'mime', ''));
      Severity: Minor
      Found in classes/Feed.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status