bnomei/kirby3-janitor

View on GitHub

Showing 10 of 10 total issues

Function job has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function job(): array
    {
        $time = time();
        $climate = \Bnomei\Janitor::climate();

Severity: Minor
Found in classes/BackupZipJob.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function job has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function job(): array
    {
        $climate = Janitor::climate();
        $progress = null;
        $verbose = $climate ? $climate->arguments->defined('verbose') : false;
Severity: Minor
Found in classes/RenderJob.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function job has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function job(): array
    {
        $climate = Janitor::climate();
        $progress = null;
        $verbose = $climate ? $climate->arguments->defined('verbose') : false;
Severity: Minor
Found in classes/ThumbsJob.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method job has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function job(): array
    {
        $time = time();
        $climate = \Bnomei\Janitor::climate();

Severity: Major
Found in classes/BackupZipJob.php - About 3 hrs to fix

    Method job has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function job(): array
        {
            $climate = Janitor::climate();
            $progress = null;
            $verbose = $climate ? $climate->arguments->defined('verbose') : false;
    Severity: Major
    Found in classes/ThumbsJob.php - About 3 hrs to fix

      Method job has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function job(): array
          {
              $climate = Janitor::climate();
              $progress = null;
              $verbose = $climate ? $climate->arguments->defined('verbose') : false;
      Severity: Major
      Found in classes/RenderJob.php - About 3 hrs to fix

        Function job has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function job(): array
            {
                $dir = kirby()->root('sessions');
                $removed = 0;
                $finder = new Finder();
        Severity: Minor
        Found in classes/FlushSessionFilesJob.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function job has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function job(): array
            {
                $dir = kirby()->roots()->cache();
                $removed = 0;
                $finder = new Finder();
        Severity: Minor
        Found in classes/CleanCacheFilesJob.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $object = new $job(
                    page(str_replace('+', '/', urldecode(A::get($data, 'contextPage', '')))),
                    str_replace('+S_L_A_S_H+', '/', urldecode(A::get($data, 'contextData', '')))
                );
        Severity: Minor
        Found in classes/Janitor.php and 1 other location - About 45 mins to fix
        classes/Janitor.php on lines 136..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    $return = $job(
                        page(str_replace('+', '/', urldecode(A::get($data, 'contextPage', '')))),
                        str_replace('+S_L_A_S_H+', '/', urldecode(A::get($data, 'contextData', '')))
                    );
        Severity: Minor
        Found in classes/Janitor.php and 1 other location - About 45 mins to fix
        classes/Janitor.php on lines 158..161

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language