bnomei/kirby3-mailjet

View on GitHub

Showing 8 of 12 total issues

Mailjet has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

final class Mailjet
{
    /** @var Client */
    private $client;

Severity: Minor
Found in classes/Mailjet.php - About 3 hrs to fix

    File MailjetCampaignDraft.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    namespace Bnomei;
    Severity: Minor
    Found in classes/MailjetCampaignDraft.php - About 2 hrs to fix

      Function getId has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getId($name): ?int
          {
              $id = null;
              if (ctype_digit($name)) {
                  $segid = intval($name);
      Severity: Minor
      Found in classes/MailjetSegments.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getId has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getId($name): ?int
          {
              $id = null;
              if (ctype_digit($name)) {
                  $id = intval($name);
      Severity: Minor
      Found in classes/MailjetContactslists.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method schedule has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function schedule(): bool
          {
              if (! $this->campaign || ! $this->datetime) {
                  return false;
              }
      Severity: Minor
      Found in classes/MailjetCampaignDraft.php - About 1 hr to fix

        Method __construct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct(array $options = [])
            {
                $defaults = [
                    'debug' => option('debug'),
                    'log' => option('bnomei.mailjet.log.fn'),
        Severity: Minor
        Found in classes/Mailjet.php - About 1 hr to fix

          Function set has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function set(string $email, array $data): bool
              {
                  // find
                  $response = $this->client->get(Resources::$Contactdata, [
                      'id' => strtolower($email),
          Severity: Minor
          Found in classes/MailjetContactProperties.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function write(string $msg = '', string $level = 'info', ?array $context = null): bool
              {
                  if ($this->logger && is_callable($this->logger)) {
                      if (!$this->debug && $level == 'debug') {
                          // skip but...
          Severity: Minor
          Found in classes/MailjetLog.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language