bnomei/kirby3-srcset

View on GitHub

Showing 10 of 11 total issues

Function dataFromTag has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function dataFromTag(KirbyTag $tag)
    {
        $data = [];
        foreach ($this->attrKeys() as $attr) {
            $val = $tag->$attr;
Severity: Minor
Found in classes/Bnomei/Srcset.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function normalizeData has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function normalizeData(array $data)
    {
        $norm = [];
        foreach ($data as $key => $val) {
            if (is_string($val) && $val === 'true') {
Severity: Minor
Found in classes/Bnomei/Srcset.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method applySrcset has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function applySrcset(string $text, array $data = []): string
    {
        $srcfile = new SrcsetFile(
            A::get($data, 'file'),
            A::get($data, 'sizes'),
Severity: Minor
Found in classes/Bnomei/Srcset.php - About 1 hr to fix

    Method dataFromTag has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function dataFromTag(KirbyTag $tag)
        {
            $data = [];
            foreach ($this->attrKeys() as $attr) {
                $val = $tag->$attr;
    Severity: Minor
    Found in classes/Bnomei/Srcset.php - About 1 hr to fix

      Function imageKirbytagFromData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function imageKirbytagFromData(array $data = []): string
          {
              $attrs = ['(image: ' . self::PLACEHOLDER]; // A::get($data, 'value')
              $lazy = A::get($data, 'lazy');
              if ($lazy) {
      Severity: Minor
      Found in classes/Bnomei/Srcset.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              'lazysrcset' => function ($options = []) {
                  if ($this === null) {
                      return \Kirby\Cms\Html::img('', ['alt' => 'lazysrcset can not create srcset from null in fileMethod']);
                  }
                  if (is_string($options)) {
      Severity: Minor
      Found in index.php and 1 other location - About 45 mins to fix
      index.php on lines 34..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              'lazySrcset' => function ($options = []) {
                  if ($this === null) {
                      return \Kirby\Cms\Html::img('', ['alt' => 'lazysrcset can not create srcset from null in fileMethod']);
                  }
                  if (is_string($options)) {
      Severity: Minor
      Found in index.php and 1 other location - About 45 mins to fix
      index.php on lines 24..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(File $file, $sizes = null, ?int $width = null, ?int $height = null, ?int $quality = null)
      Severity: Minor
      Found in classes/Bnomei/SrcsetFile.php - About 35 mins to fix

        Function applySrcset has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function applySrcset(string $text, array $data = []): string
            {
                $srcfile = new SrcsetFile(
                    A::get($data, 'file'),
                    A::get($data, 'sizes'),
        Severity: Minor
        Found in classes/Bnomei/Srcset.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct($data = null, array $options = [])
            {
                if (is_a($data, 'Kirby\Cms\KirbyTag')) {
                    $this->parent = $data->parent();
                    $options = $this->dataFromTag($data);
        Severity: Minor
        Found in classes/Bnomei/Srcset.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language