boomerdigital/solidus_amazon_payments

View on GitHub

Showing 4 of 6 total issues

Method authorize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def authorize(amount, amazon_checkout, gateway_options={})
      if amount < 0
        return ActiveMerchant::Billing::Response.new(true, "Success", {})
      end

Severity: Minor
Found in app/models/spree/gateway/amazon.rb - About 1 hr to fix

    Method authorize has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def authorize(amount, amazon_checkout, gateway_options={})
          if amount < 0
            return ActiveMerchant::Billing::Response.new(true, "Success", {})
          end
    
    
    Severity: Minor
    Found in app/models/spree/gateway/amazon.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method close_order_reference! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def close_order_reference!
        response = mws.close_order_reference
        parsed_response = Hash.from_xml(response.body) rescue nil
    
        if response.success
    Severity: Minor
    Found in app/models/spree_amazon/order.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method confirm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def confirm
        if Spree::OrderUpdateAttributes.new(current_order, checkout_params, request_env: request.headers.env).apply
          while current_order.next
          end
    
    
    Severity: Minor
    Found in app/controllers/spree/amazon_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language