boxus-plants/boxus

View on GitHub

Showing 3 of 5 total issues

Function _digital_out has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _digital_out(self, pin, val):
        if self.control == 'native':
            value = GPIO.HIGH if val == 1 else GPIO.LOW

            GPIO.setmode(GPIO.BCM)
Severity: Minor
Found in boxus/controllable.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function human_interval_to_seconds has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def human_interval_to_seconds(val, units):
    assert units in [
            'second', 'seconds',
            'minute', 'minutes',
            'hour',   'hours',
Severity: Minor
Found in boxus/utils.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function seed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def seed(self, seed_path):
        seed = yaml.load(open(seed_path, 'r').read())

        for db_name, Cls in [['sensors', Sensor], ['devices', Device]]:
            for r in seed[db_name]:
Severity: Minor
Found in boxus/db.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language