brainopia/sidekiq-limit_fetch

View on GitHub

Showing 7 of 9 total issues

Class Semaphore has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Semaphore
        PREFIX = 'limit_fetch'

        attr_reader :local_busy

Severity: Minor
Found in lib/sidekiq/limit_fetch/global/semaphore.rb - About 3 hrs to fix

    Method start has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def start(capsule_or_options)
            config = Sidekiq::LimitFetch.post_7? ? capsule_or_options.config : capsule_or_options
    
            @queues = config[:queues].map do |queue|
              if queue.is_a? Array
    Severity: Minor
    Found in lib/sidekiq/limit_fetch/queues.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method redis_eval has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def redis_eval(script_name, args)
              Sidekiq.redis do |it|
                it.evalsha send("redis_#{script_name}_sha"), [], args
              rescue Sidekiq::LimitFetch::RedisCommandError => e
                raise unless e.message.include? 'NOSCRIPT'
    Severity: Minor
    Found in lib/sidekiq/limit_fetch/global/selector.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method redis_brpop has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def redis_brpop(queues)
          if queues.empty?
            sleep TIMEOUT  # there are no queues to handle, so lets sleep
            []             # and return nothing
          else
    Severity: Minor
    Found in lib/sidekiq/limit_fetch.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def add(queues)
            return unless queues
    
            queues.each do |queue|
              next if @queues.include? queue
    Severity: Minor
    Found in lib/sidekiq/limit_fetch/queues.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method redis_retryable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def redis_retryable
          yield
        rescue RedisBaseConnectionError
          sleep TIMEOUT
          retry
    Severity: Minor
    Found in lib/sidekiq/limit_fetch.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method remove has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def remove(queues)
            return unless queues
    
            queues.each do |queue|
              next unless @queues.include? queue
    Severity: Minor
    Found in lib/sidekiq/limit_fetch/queues.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language