Sign upLogin

brokencube/automatorm

View on GitHub
Star

Showing 452 of 452 total issues

Model has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class Model implements \JsonSerializable
{
    // Flags
    const COUNT_ONLY = 1;
Severity: Minor
Found in src/Orm/Model.php - About 3 hrs to fix

    Function factoryObjectCache has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        final public static function factoryObjectCache($ids, $classOrTable = null, Schema $schema = null, $forceRefresh = false)
    {
        $schema = $schema ?: Schema::get(static::getNamespace());
        list(,$table) = $schema->guessContext($classOrTable ?: get_called_class());
        $namespace = $schema->namespace;
    Severity: Minor
    Found in src/Orm/Model.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Collection.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace Automatorm\Orm;

use Automatorm\Exception;
use Automatorm\OperatorParser;
    Severity: Minor
    Found in src/Orm/Collection.php - About 3 hrs to fix

      Function getTableData has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getTableData($table, $where)
    {
        $returnData = [];
        
        foreach ($this->data->getTable($table) as $id => $row) {
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method makeMessage has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function makeMessage($code, $data)
    {
        switch ($code) {
            case 'NO_GENERATED_SCHEMA':
                return 'NO_GENERATED_SCHEMA: Could not find a schema definition for namespace: ' . $data;
      Severity: Major
      Found in src/Exception/Model.php - About 2 hrs to fix

        Function commit has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            public function commit($mode, $table, $id, $data, $externalData, $schema) : int
    {
        // Create a new query
        $query = new Query($this->connection);
        Severity: Minor
        Found in src/DataLayer/Database/DataAccess.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct($column)
    {
        // Cowardly refuse to process SqlStrings
        if ($column instanceof SqlString) {
            $this->column = (string) $column;
        Severity: Major
        Found in src/Database/QueryBuilder/Column.php - About 2 hrs to fix

          Function __construct has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($table)
    {
        if (is_string($table)) {
            preg_match(
                '/^
          Severity: Minor
          Found in src/Database/QueryBuilder/Table.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __construct has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct(Column $column, $affix, $value)
    {
        $this->column = $column;
        $this->comparitor = '=';
        $this->value = $value;
          Severity: Minor
          Found in src/Database/QueryBuilder/Expression.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __construct($table)
    {
        if (is_string($table)) {
            preg_match(
                '/^
          Severity: Major
          Found in src/Database/QueryBuilder/Table.php - About 2 hrs to fix

            Method generate has 61 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function generate($path, Schema $schema)
    {
        $namespace = $schema->namespace;
        
        foreach ($schema->model as $model) {
            Severity: Major
            Found in src/Generator/Model.php - About 2 hrs to fix

              File Model.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
namespace Automatorm\Orm;

use Automatorm\Exception;
              Severity: Minor
              Found in src/Orm/Model.php - About 2 hrs to fix

                Function generateForeignKeys has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function generateForeignKeys(Data $datastore)
    {
        $data = $datastore->data;
        $tableName = null;
        $keys = [];
                Severity: Minor
                Found in src/DataLayer/Fake/SchemaGenerator.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function generateTableList has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function generateTableList(Data $datastore)
    {
        $data = $datastore->data;
        foreach(preg_split('~[\r\n]+~', $data) as $line) {
            if (empty($line) or ctype_space($line)) {
                Severity: Minor
                Found in src/DataLayer/Fake/SchemaGenerator.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __construct has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function __construct(Column $column, $affix, $value)
    {
        $this->column = $column;
        $this->comparitor = '=';
        $this->value = $value;
                Severity: Major
                Found in src/Database/QueryBuilder/Expression.php - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getChildren()
    {
        // Find all direct child/parent relationships
        $query = new Query($this->getConnection());
        $query->sql(
                  Severity: Major
                  Found in src/Orm/Traits/ClosureTree.php and 1 other location - About 2 hrs to fix
                  src/Orm/Traits/ClosureTree.php on lines 174..189

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 122.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getDescendants()
    {
        // Find all direct child/parent relationships
        $query = new Query($this->getConnection());
        $query->sql(
                  Severity: Major
                  Found in src/Orm/Traits/ClosureTree.php and 1 other location - About 2 hrs to fix
                  src/Orm/Traits/ClosureTree.php on lines 157..172

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 122.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method filter has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function filter($filter, $invertAffix = false)
    {
        $copy = $this->container;
        
        if (is_array($filter)) {
                  Severity: Minor
                  Found in src/Orm/Collection.php - About 1 hr to fix

                    Method commit has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function commit($mode, $table, $id, $data, $externalData, $schema) : int
    {
        // Create a new query
        $query = new Query($this->connection);
                    Severity: Minor
                    Found in src/DataLayer/Database/DataAccess.php - About 1 hr to fix

                      Method commit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function commit($mode, $table, $id, $data, $externalData, $schema) : int
    {
        if ($mode == 'delete') {
            $this->data->delete($table, $id);
            return $id;
                      Severity: Minor
                      Found in src/DataLayer/Fake/DataAccess.php - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language