brokencube/automatorm

View on GitHub
src/DataLayer/Fake/DataAccess.php

Summary

Maintainability
C
1 day
Test Coverage

Function commit has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public function commit($mode, $table, $id, $data, $externalData, $schema) : int
    {
        if ($mode == 'delete') {
            $this->data->delete($table, $id);
            return $id;
Severity: Minor
Found in src/DataLayer/Fake/DataAccess.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getTableData has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getTableData($table, $where)
    {
        $returnData = [];
        
        foreach ($this->data->getTable($table) as $id => $row) {
Severity: Minor
Found in src/DataLayer/Fake/DataAccess.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method commit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function commit($mode, $table, $id, $data, $externalData, $schema) : int
    {
        if ($mode == 'delete') {
            $this->data->delete($table, $id);
            return $id;
Severity: Minor
Found in src/DataLayer/Fake/DataAccess.php - About 1 hr to fix

    Method commit has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function commit($mode, $table, $id, $data, $externalData, $schema) : int
    Severity: Minor
    Found in src/DataLayer/Fake/DataAccess.php - About 45 mins to fix

      The method commit() has an NPath complexity of 800. The configured NPath complexity threshold is 200.
      Open

          public function commit($mode, $table, $id, $data, $externalData, $schema) : int
          {
              if ($mode == 'delete') {
                  $this->data->delete($table, $id);
                  return $id;
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method getTableData() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          protected function getTableData($table, $where)
          {
              $returnData = [];
              
              foreach ($this->data->getTable($table) as $id => $row) {
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method commit() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
      Open

          public function commit($mode, $table, $id, $data, $externalData, $schema) : int
          {
              if ($mode == 'delete') {
                  $this->data->delete($table, $id);
                  return $id;
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using undefined variables such as '$return' which will lead to PHP notices.
      Open

                  $return[] = [
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
      {
          private function bar()
          {
              // $message is undefined
              echo $message;
          }
      }

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$return' which will lead to PHP notices.
      Open

              return $return;
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
      {
          private function bar()
          {
              // $message is undefined
              echo $message;
          }
      }

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid assigning values to variables in if clauses and the like (line '46', column '18').
      Open

          public function commit($mode, $table, $id, $data, $externalData, $schema) : int
          {
              if ($mode == 'delete') {
                  $this->data->delete($table, $id);
                  return $id;
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Avoid unused parameters such as '$options'.
      Open

          public function getDataCount($table, $where, array $options = []) : int
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
      {
          private function bar($howdy)
          {
              // $howdy is not used
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Avoid unused local variables such as '$id'.
      Open

              foreach ($this->data->getTable($table) as $id => $row) {
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
          public function doSomething()
          {
              $i = 5; // Unused
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Call with 2 arg(s) to \natsort() which only takes 1 arg(s)
      Open

                                  $result = natsort($b[$sort], $a[$sort]);
      Severity: Info
      Found in src/DataLayer/Fake/DataAccess.php by phan

      Variable $options is undeclared
      Open

                          foreach ((array) $options['sort'] as $sortby) {
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phan

      Call with 2 arg(s) to \natsort() which only takes 1 arg(s)
      Open

                                  $result = natsort($a[$sort], $b[$sort]);
      Severity: Info
      Found in src/DataLayer/Fake/DataAccess.php by phan

      Argument 2 (cmp_function) is Closure(mixed,mixed):bool but \usort() takes callable(mixed,mixed):int
      Open

                      usort($returnData, function ($a, $b) use ($sort) {
      Severity: Minor
      Found in src/DataLayer/Fake/DataAccess.php by phan

      Variable $return was undeclared, but array fields are being added to it.
      Open

                  $return[] = [
      Severity: Info
      Found in src/DataLayer/Fake/DataAccess.php by phan

      Line exceeds 120 characters; contains 128 characters
      Open

                      if ($type == 'datetime' and array_key_exists($column, $data) and $data[$column] instanceof \DateTimeInterface) {

      Whitespace found at end of line
      Open

              }        

      There are no issues that match your filters.

      Category
      Status