brokencube/automatorm

View on GitHub
src/Database/QueryBuilder/Column.php

Summary

Maintainability
D
1 day
Test Coverage

Function __construct has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($column)
    {
        // Cowardly refuse to process SqlStrings
        if ($column instanceof SqlString) {
            $this->column = (string) $column;
Severity: Minor
Found in src/Database/QueryBuilder/Column.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($column)
    {
        // Cowardly refuse to process SqlStrings
        if ($column instanceof SqlString) {
            $this->column = (string) $column;
Severity: Major
Found in src/Database/QueryBuilder/Column.php - About 2 hrs to fix

    The method __construct() has an NPath complexity of 11394. The configured NPath complexity threshold is 200.
    Open

        public function __construct($column)
        {
            // Cowardly refuse to process SqlStrings
            if ($column instanceof SqlString) {
                $this->column = (string) $column;
    Severity: Minor
    Found in src/Database/QueryBuilder/Column.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
        function bar() {
            // lots of complicated code
        }
    }

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method __construct() has a Cyclomatic Complexity of 30. The configured cyclomatic complexity threshold is 10.
    Open

        public function __construct($column)
        {
            // Cowardly refuse to process SqlStrings
            if ($column instanceof SqlString) {
                $this->column = (string) $column;
    Severity: Minor
    Found in src/Database/QueryBuilder/Column.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid unused parameters such as '$query'.
    Open

        public function renderFunction(QueryBuilder $query, string $function) : string
    Severity: Minor
    Found in src/Database/QueryBuilder/Column.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$query'.
    Open

        public function render(QueryBuilder $query) : string
    Severity: Minor
    Found in src/Database/QueryBuilder/Column.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if ($columnparts[5] ?: $columnparts[6]) {
                    $this->database = $this->escape($columnparts[1] ?: $columnparts[2]);
                    $this->schema = $this->escape($columnparts[3] ?: $columnparts[4]);
                    $this->column = $this->escape($columnparts[5] ?: $columnparts[6]);
                } elseif ($columnparts[3] ?: $columnparts[4]) {
    Severity: Major
    Found in src/Database/QueryBuilder/Column.php and 1 other location - About 7 hrs to fix
    src/Database/QueryBuilder/Table.php on lines 39..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 227.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status