Sign upLogin

brokencube/circuit

View on GitHub
Star

Showing 6 of 67 total issues

Method process has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(Request $request) : Response
    {
        // Try and run the next middleware
        $next = next($this->prerouteMiddleware);
        if ($next instanceof Middleware) {
Severity: Minor
Found in src/Router.php - About 1 hr to fix

    Method process has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function process(Request $request) : Response
    {
        $router = $request->attributes->get('router');
        
        $next = next($this->middlewareStack);
    Severity: Minor
    Found in src/HandlerContainer.php - About 1 hr to fix

      Function process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function process(Request $request, Delegate $delegate) : Response
    {
        $params = $request->attributes->get('controller');
        $args = $params->args;
      Severity: Minor
      Found in src/Middleware/ParameterMatcher.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct($route, $class, $method, $args, Container $container)
      Severity: Minor
      Found in src/ControllerParams.php - About 35 mins to fix

        Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function process(Request $request) : Response
    {
        $router = $request->attributes->get('router');
        
        $next = next($this->middlewareStack);
        Severity: Minor
        Found in src/HandlerContainer.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return new Response(
                $return,
                Response::HTTP_OK,
                array('content-type' => 'text/html')
            );
        Severity: Major
        Found in src/HandlerContainer.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language