brynary/rack-bug

View on GitHub

Showing 67 of 86 total issues

File jquery-1.3.2.js has 3038 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery JavaScript Library v1.3.2
 * http://jquery.com/
 *
 * Copyright (c) 2009 John Resig
Severity: Major
Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 wk to fix

    Function ajax has 163 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        ajax: function( s ) {
            // Extend the settings, but re-extend 's' so that it can be
            // checked again later (in the test suite, specifically)
            s = jQuery.extend(true, s, jQuery.extend(true, {}, jQuery.ajaxSettings, s));
    
    
    Severity: Major
    Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 6 hrs to fix

      Function SHA1 has 130 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      document.SHA1 = function(msg) {
        function rotate_left(n,s) {
          var t4 = ( n<<s ) | (n>>>(32-s));
          return t4;
        };
      Severity: Major
      Found in lib/rack/bug/public/__rack_bug__/bookmarklet.js - About 5 hrs to fix

        Function SHA1 has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

        document.SHA1 = function(msg) {
          function rotate_left(n,s) {
            var t4 = ( n<<s ) | (n>>>(32-s));
            return t4;
          };
        Severity: Minor
        Found in lib/rack/bug/public/__rack_bug__/bookmarklet.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                    if ( typeof elem === "string" ) {
                        // Fix "XHTML"-style tags in all browsers
                        elem = elem.replace(/(<(\w+)[^>]*?)\/>/g, function(all, front, tag){
                            return tag.match(/^(abbr|br|col|img|input|link|meta|param|hr|area|embed)$/i) ?
                                all :
        Severity: Critical
        Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 4 hrs to fix

          Function Sizzle has 93 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var Sizzle = function(selector, context, results, seed) {
              results = results || [];
              context = context || document;
          
              if ( context.nodeType !== 1 && context.nodeType !== 9 )
          Severity: Major
          Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 3 hrs to fix

            Consider simplifying this complex logical expression.
            Open

            if ( document.documentElement["getBoundingClientRect"] )
                jQuery.fn.offset = function() {
                    if ( !this[0] ) return { top: 0, left: 0 };
                    if ( this[0] === this[0].ownerDocument.body ) return jQuery.offset.bodyOffset( this[0] );
                    var box  = this[0].getBoundingClientRect(), doc = this[0].ownerDocument, body = doc.body, docElem = doc.documentElement,
            Severity: Critical
            Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 3 hrs to fix

              Function clean has 72 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  clean: function( elems, context, fragment ) {
                      context = context || document;
              
                      // !context.createElement fails in IE with an error but returns typeof 'object'
                      if ( typeof context.createElement === "undefined" )
              Severity: Major
              Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 2 hrs to fix

                Consider simplifying this complex logical expression.
                Open

                        if ( event.pageX == null && event.clientX != null ) {
                            var doc = document.documentElement, body = document.body;
                            event.pageX = event.clientX + (doc && doc.scrollLeft || body && body.scrollLeft || 0) - (doc.clientLeft || 0);
                            event.pageY = event.clientY + (doc && doc.scrollTop || body && body.scrollTop || 0) - (doc.clientTop || 0);
                        }
                Severity: Critical
                Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 2 hrs to fix

                  Function filter has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Sizzle.filter = function(expr, set, inplace, not){
                      var old = expr, result = [], curLoop = set, match, anyFound,
                          isXMLFilter = set && set[0] && isXML(set[0]);
                  
                      while ( expr && set.length ) {
                  Severity: Major
                  Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 2 hrs to fix

                    Function attr has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        attr: function( elem, name, value ) {
                            // don't set attributes on text and comment nodes
                            if (!elem || elem.nodeType == 3 || elem.nodeType == 8)
                                return undefined;
                    
                    
                    Severity: Major
                    Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 2 hrs to fix

                      Function remove has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          remove: function(elem, types, handler) {
                              // don't do events on text and comment nodes
                              if ( elem.nodeType == 3 || elem.nodeType == 8 )
                                  return;
                      
                      
                      Severity: Minor
                      Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix

                        Function val has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            val: function( value ) {
                                if ( value === undefined ) {            
                                    var elem = this[0];
                        
                                    if ( elem ) {
                        Severity: Minor
                        Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix

                          Function init has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              init: function() {
                                var current = null;
                                $('#rack_bug ul.panels li a').click(function() {
                                  current = $('#rack_bug #' + this.className);
                                  
                          Severity: Minor
                          Found in lib/rack/bug/public/__rack_bug__/bug.js - About 1 hr to fix

                            Method root_for_backtrace_filtering has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def root_for_backtrace_filtering(sub_path = nil)
                                    if defined?(Rails) && Rails.respond_to?(:root)
                                      (sub_path ? Rails.root.join(sub_path) : Rails.root).to_s
                                    else
                                      root = if defined?(RAILS_ROOT)
                            Severity: Minor
                            Found in lib/rack/bug/filtered_backtrace.rb - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function trigger has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                trigger: function( event, data, elem, bubbling ) {
                                    // Event object or event type
                                    var type = event.type || event;
                            
                                    if( !bubbling ){
                            Severity: Minor
                            Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix

                              Function onreadystatechange has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      var onreadystatechange = function(isTimeout){
                                          // The request was aborted, clear the interval and decrement jQuery.active
                                          if (xhr.readyState == 0) {
                                              if (ival) {
                                                  // clear poll interval
                              Severity: Minor
                              Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix

                                Function animate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    animate: function( prop, speed, easing, callback ) {
                                        var optall = jQuery.speed(speed, easing, callback);
                                
                                        return this[ optall.queue === false ? "each" : "queue" ](function(){
                                        
                                Severity: Minor
                                Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix

                                  Function add has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      add: function(elem, types, handler, data) {
                                          if ( elem.nodeType == 3 || elem.nodeType == 8 )
                                              return;
                                  
                                          // For whatever reason, IE has trouble passing the window object
                                  Severity: Minor
                                  Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix

                                    Function CHILD has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                            CHILD: function(elem, match){
                                                var type = match[1], node = elem;
                                                switch (type) {
                                                    case 'only':
                                                    case 'first':
                                    Severity: Minor
                                    Found in lib/rack/bug/public/__rack_bug__/jquery-1.3.2.js - About 1 hr to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language