bskim45/fastlane-plugin-google_drive

View on GitHub

Showing 14 of 25 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if file.nil?
          UI.error("No file or folder was found.")
        else
          Actions.lane_context[SharedValues::GDRIVE_FILE_ID] = file.resource_id.split(':').last
          Actions.lane_context[SharedValues::GDRIVE_FILE_TITLE] = file.title
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 36..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if file.nil?
          UI.error('No file or folder was found.')
        else
          Actions.lane_context[SharedValues::GDRIVE_FILE_ID] = file.resource_id.split(':').last
          Actions.lane_context[SharedValues::GDRIVE_FILE_TITLE] = file.title
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_id_action.rb on lines 32..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                      env_name: 'GDRIVE_KEY_FILE',
                                      description: 'Json config file',
                                      type: String,
                                      default_value: 'drive_key.json',
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 50..57
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_id_action.rb on lines 54..63
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 58..67
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 59..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(
            key: :drive_keyfile,
            env_name: 'GDRIVE_KEY_FILE',
            description: 'The path to the json keyfile',
            type: String,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 50..57
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 58..67
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 49..56
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 59..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(
            key: :drive_keyfile,
            env_name: 'GDRIVE_KEY_FILE',
            description: 'The path to the json keyfile',
            type: String,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 50..57
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_id_action.rb on lines 54..63
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 49..56
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 59..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                       env_name: 'GDRIVE_KEY_FILE',
                                       description: 'Json config file',
                                       type: String,
                                       default_value: 'drive_key.json',
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_id_action.rb on lines 54..63
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 58..67
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 49..56
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 59..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :drive_keyfile,
                                      env_name: 'GDRIVE_KEY_FILE',
                                      description: 'Json config file',
                                      type: String,
                                      default_value: 'drive_key.json',
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 50..57
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_id_action.rb on lines 54..63
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 58..67
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 49..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(
            key: :file_id,
            env_name: 'GDRIVE_TARGET_FILE_ID',
            description: 'Target file or folder ID to check the existence',
            optional: false,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 72..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :folder_id,
                                      env_name: "GDRIVE_UPLOAD_FOLDER_ID",
                                      description: "Upload target folder id",
                                      optional: false,
                                      type: String,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 64..71
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 76..85
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 86..95
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 63..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :file_id,
                                      env_name: "GDRIVE_UPDATE_FILE_ID",
                                      description: "Target file id to update the content",
                                      optional: false,
                                      type: String,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 64..71
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 76..85
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 86..95
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 73..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(
            key: :file_title,
            env_name: 'GDRIVE_TARGET_FILE_TITLE',
            description: 'Target file or folder title to check the existence',
            optional: false,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 64..71
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 76..85
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 63..70
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 73..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :folder_id,
                                       env_name: "GDRIVE_UPLOAD_FOLDER_ID",
                                       description: "Upload target folder id",
                                       optional: false,
                                       type: String,
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 76..85
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 86..95
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 63..70
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 73..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(
            key: :parent_folder_id,
            env_name: 'GDRIVE_PARENT_FOLDER_ID',
            description: 'The parent folder ID of the target file or folder to check the existence',
            optional: false,
lib/fastlane/plugin/google_drive/actions/create_google_drive_folder_action.rb on lines 64..71
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_title_action.rb on lines 86..95
lib/fastlane/plugin/google_drive/actions/update_google_drive_file_action.rb on lines 63..70
lib/fastlane/plugin/google_drive/actions/upload_to_google_drive_action.rb on lines 73..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          FastlaneCore::ConfigItem.new(key: :folder_title,
                                       env_name: "GDRIVE_FOLDER_NAME",
                                       description: "Folder title of new one",
                                       optional: false,
                                       type: String,
lib/fastlane/plugin/google_drive/actions/find_google_drive_file_by_id_action.rb on lines 72..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language