btnpushnmunky/pygallerycreator

View on GitHub

Showing 6 of 6 total issues

Function create_images has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def create_images(user_images_dir, base_save_path):
    """
    Open the original image files and save a thumb and gallery version.

    :param user_images_dir: User's image directory path as a string
Severity: Minor
Found in pygallerycreator/image_processor.py - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def test_get_user_path(monkeypatch):
        """Make sure getting the user's path works."""
        monkeypatch.setitem(__builtins__, "input", lambda x: "user dest dir")
        user_path = main.get_user_path()
        assert "user dest dir" in user_path
    Severity: Major
    Found in pygallerycreator/test_main.py and 1 other location - About 1 hr to fix
    pygallerycreator/test_main.py on lines 21..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def test_get_raw_images(monkeypatch):
        """Make sure we have a path to raw images."""
        monkeypatch.setitem(__builtins__, "input", lambda x: "test_imgs")
        raw_images = main.get_raw_image_dir()
        assert "test_imgs" in raw_images
    Severity: Major
    Found in pygallerycreator/test_main.py and 1 other location - About 1 hr to fix
    pygallerycreator/test_main.py on lines 7..11

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function create_images has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def create_images(user_images_dir, base_save_path):
        """
        Open the original image files and save a thumb and gallery version.
    
        :param user_images_dir: User's image directory path as a string
    Severity: Minor
    Found in pygallerycreator/image_processor.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def test_large_file_creation():
        assert len(os.listdir(os.path.join(TEST_DIR_PATH, "large_imgs"))) == 3
    Severity: Minor
    Found in pygallerycreator/test_image_processor.py and 1 other location - About 30 mins to fix
    pygallerycreator/test_image_processor.py on lines 25..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    def test_thumbnail_creation():
        assert len(os.listdir(os.path.join(TEST_DIR_PATH, "thumbs"))) == 3
    Severity: Minor
    Found in pygallerycreator/test_image_processor.py and 1 other location - About 30 mins to fix
    pygallerycreator/test_image_processor.py on lines 21..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language