btnpushnmunky/pygallerycreator

View on GitHub

Showing 2 of 6 total issues

Function create_images has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def create_images(user_images_dir, base_save_path):
    """
    Open the original image files and save a thumb and gallery version.

    :param user_images_dir: User's image directory path as a string
Severity: Minor
Found in pygallerycreator/image_processor.py - About 1 hr to fix

    Function create_images has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def create_images(user_images_dir, base_save_path):
        """
        Open the original image files and save a thumb and gallery version.
    
        :param user_images_dir: User's image directory path as a string
    Severity: Minor
    Found in pygallerycreator/image_processor.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language