Sign upLogin

buren/honey_format

View on GitHub
Star

Showing 7 of 7 total issues

Method parse_options has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_options(argv:)
      input_path = nil
      columns = nil
      output_path = nil
      delimiter = ','
Severity: Major
Found in lib/honey_format/cli/cli.rb - About 2 hrs to fix

    Method parse_options has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def parse_options(argv:)
      input_path = nil
      benchmark_time = 30
      benchmark_warmup = 5
      lines_multipliers = [1]
    Severity: Minor
    Found in lib/honey_format/cli/benchmark_cli.rb - About 1 hr to fix

      Method key_count_to_deduplicated_array has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.key_count_to_deduplicated_array(data)
      array = []
      count_occurences(data).each do |key, value|
        next array << key if value == 1
      Severity: Minor
      Found in lib/honey_format/helpers/helpers.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse_options(argv:)
      input_path = nil
      benchmark_time = 30
      benchmark_warmup = 5
      lines_multipliers = [1]
      Severity: Minor
      Found in lib/honey_format/cli/benchmark_cli.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hash_converter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def hash_converter(hash)
      lambda { |value, index|
        # support strings and symbol keys interchangeably
        column = hash.fetch(value) do
          key = value.respond_to?(:to_sym) ? value.to_sym : value
      Severity: Minor
      Found in lib/honey_format/matrix/header.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      HoneyFormat.configure do |config|
  config.converter_registry.register(:upcased, proc { |v| v.upcase })
  config.converter_registry.register(:country, proc { |v| v == 'SE' ? 'SWEDEN' : v })
      Severity: Minor
      Found in examples/convert_values.rb and 1 other location - About 20 mins to fix
      examples/complete_example.rb on lines 15..17

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      HoneyFormat.configure do |config|
  config.converter_registry.register(:upcased, proc { |v| v.upcase })
  config.converter_registry.register(:country, proc { |v| v == 'SE' ? 'SWEDEN' : v })
      Severity: Minor
      Found in examples/complete_example.rb and 1 other location - About 20 mins to fix
      examples/convert_values.rb on lines 11..13

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language