buttercup-pw/buttercup-core

View on GitHub

Showing 67 of 185 total issues

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in source/io/formatB/compare.ts - About 30 mins to fix

    Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        async update({ skipDiff = false } = {}) {
            const didUpdate = await this._enqueueStateChange(
                () =>
                    (skipDiff ? Promise.resolve(false) : this.localDiffersFromRemote()).then(differs => {
                        if (differs) {
    Severity: Minor
    Found in source/core/VaultSource.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function prepare has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        async prepare() {
            this._entries = [];
            this._scores = {};
            for (const target of this._targets) {
                // Get scores
    Severity: Minor
    Found in source/search/BaseSearch.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function incrementScore has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        async incrementScore(vaultID: VaultID, entryID: EntryID, url: string) {
            const scoresRaw = await this._memory.getValue(`bcup_search_${vaultID}`);
            let vaultScore = {};
            if (scoresRaw) {
                try {
    Severity: Minor
    Found in source/search/BaseSearch.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setEntryValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function setEntryValue(
        entry: Entry,
        propertyType: EntryPropertyType,
        property: string,
        value: string,
    Severity: Minor
    Found in source/facades/entry.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function apply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            apply: compiler => {
                compiler.hooks.afterEmit.tap("AfterEmitPlugin", compilation => {
                    exec("./scripts/fix_web_typings.sh", (err, stdout, stderr) => {
                        if (stdout) process.stdout.write(stdout);
                        if (stderr) process.stderr.write(stderr);
    Severity: Minor
    Found in webpack.config.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildClient has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    export function buildClient(token: string) {
        const encrypt = getSharedAppEnv().getProperty("crypto/v1/encryptText");
        const decrypt = getSharedAppEnv().getProperty("crypto/v1/decryptText");
        return {
            readdir: (remotePath, callback) => {
    Severity: Minor
    Found in source/web/localFileClient.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language