buttercup-pw/buttercup-core

VaultFormatB has 48 functions (exceeds 20 allowed). Consider refactoring.

Open

export default class VaultFormatB extends VaultFormat {
    static encodeRaw(rawContent: History, credentials: Credentials): Promise<string> {
        const compress = getSharedAppEnv().getProperty("compression/v2/compressText");
        const encrypt = getSharedAppEnv().getProperty("crypto/v1/encryptText");
        const { masterPassword } = getCredentials(credentials.id);

File VaultFormatB.ts has 338 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import VaultFormat from "./VaultFormat";
import Vault from "../core/Vault";
import { generateUUID } from "../tools/uuid";
import { getSharedAppEnv } from "../env/appEnv";
import { getCredentials } from "../credentials/channel";

Function getEntryChanges has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    getEntryChanges(entrySource: FormatBEntry): Array<EntryChange> {
        return Object.keys(entrySource.p).reduce(
            (changes, property) => [
                ...changes,
                ...entrySource.p[property].history.map((histItem: FormatBValueHistoryItem) => {

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    setGroupAttribute(groupID: GroupID, attribute: string, value: string) {
        const group = this.source.g.find((g: FormatBGroup) => g.id === groupID);
        if (!group.a[attribute]) {
            group.a[attribute] = newRawValue(value);
        } else {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    setEntryProperty(entryID: EntryID, property: string, value: string) {
        const entry = this.source.e.find((e: FormatBEntry) => e.id === entryID);
        if (!entry.p[property]) {
            entry.p[property] = newRawValue(value);
        } else {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    setEntryAttribute(entryID: EntryID, attribute: string, value: string) {
        const entry = this.source.e.find((e: FormatBEntry) => e.id === entryID);
        if (!entry.a[attribute]) {
            entry.a[attribute] = newRawValue(value);
        } else {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static encodeRaw(rawContent: History, credentials: Credentials): Promise<string> {
        const compress = getSharedAppEnv().getProperty("compression/v2/compressText");
        const encrypt = getSharedAppEnv().getProperty("crypto/v1/encryptText");
        const { masterPassword } = getCredentials(credentials.id);
        return Promise.resolve()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    findGroupContainingEntryID(id: EntryID): FormatBGroup {
        const matchingEntry = this.getAllEntries().find(entry => entry.id === id);
        if (matchingEntry) {
            return this.getAllGroups().find(group => group.id === matchingEntry.g) || null;
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    deleteEntryProperty(entryID: EntryID, property: string) {
        const entry = this.source.e.find(e => e.id === entryID);
        if (!entry.p[property]) return;
        entry.p[property].deleted = getTimestamp();
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    deleteGroupAttribute(groupID: GroupID, attribute: string) {
        const group = this.source.g.find(g => g.id === groupID);
        if (!group.a[attribute]) return;
        group.a[attribute].deleted = getTimestamp();
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    getAllGroups(parentID: GroupID = null): Array<FormatBGroup> {
        const source = this.source as FormatBVault;
        return parentID === null ? source.g : source.g.filter(group => group.g === parentID);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    getAllEntries(parentID: GroupID = null): Array<FormatBEntry> {
        const source = this.source as FormatBVault;
        return parentID === null ? source.e : source.e.filter(entry => entry.g === parentID);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    deleteEntry(entryID: EntryID) {
        const ind = this.source.e.findIndex(entry => entry.id === entryID);
        if (ind >= 0) {
            this.source.e.splice(ind, 1);
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    deleteGroup(groupID: GroupID) {
        const ind = this.source.g.findIndex(group => group.id === groupID);
        if (ind >= 0) {
            this.source.g.splice(ind, 1);
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    moveGroup(groupID: GroupID, newParentID: GroupID) {
        const group = this.source.g.find((g: FormatBGroup) => g.id === groupID);
        group.g = newParentID;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    moveEntry(entryID: EntryID, groupID: GroupID) {
        const entry = this.source.e.find((e: FormatBEntry) => e.id === entryID);
        entry.g = groupID;
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        return Promise.resolve()
            .then(() => {
                if (!hasValidSignature(encryptedContent)) {
                    throw new Error("No valid signature in vault");
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    findGroupByID(id: GroupID): FormatBGroup {
        return this.source.g.find(group => group.id === id) || null;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    findEntryByID(id: EntryID): FormatBEntry {
        return this.source.e.find(entry => entry.id === id) || null;
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    erase() {
        super.erase();
        Object.assign(this.source, emptyVault());
        this.emit("erased");
    }

• Read up
  Read up