Sign upLogin

buttercup-pw/buttercup-core

View on GitHub
Star
source/io/formatA/commands.ts

Summary

Maintainability
D
2 days
Test Coverage

File commands.ts has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
    findEntryByID,
    findGroupByID,
    findGroupContainingEntryID,
    findGroupContainingGroupID,
Severity: Minor
Found in source/io/formatA/commands.ts - About 3 hrs to fix

    Function executeSetEntryAttribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        archive: FormatAVault,
    opts: any,
    entryID: EntryID,
    attribute: string,
    value: string
    Severity: Minor
    Found in source/io/formatA/commands.ts - About 35 mins to fix

      Function executeSetEntryProperty has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          archive: FormatAVault,
    opts: any,
    entryID: EntryID,
    property: string,
    value: string
      Severity: Minor
      Found in source/io/formatA/commands.ts - About 35 mins to fix

        Function executeSetGroupAttribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            archive: FormatAVault,
    opts: any,
    groupID: GroupID,
    attribute: string,
    value: string
        Severity: Minor
        Found in source/io/formatA/commands.ts - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          export function executeSetEntryProperty(
    archive: FormatAVault,
    opts: any,
    entryID: EntryID,
    property: string,
          Severity: Major
          Found in source/io/formatA/commands.ts and 1 other location - About 1 day to fix
          source/io/formatA/commands.ts on lines 252..272

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 217.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          export function executeSetEntryAttribute(
    archive: FormatAVault,
    opts: any,
    entryID: EntryID,
    attribute: string,
          Severity: Major
          Found in source/io/formatA/commands.ts and 1 other location - About 1 day to fix
          source/io/formatA/commands.ts on lines 274..294

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 217.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status