buttercup-pw/buttercup-core

View on GitHub
source/search/BaseSearch.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function searchByURL has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    searchByURL(url: string): Array<SearchResult> {
        const incomingDomain = extractDomain(url);
        if (!incomingDomain) {
            this._results = [];
            return this._results;
Severity: Minor
Found in source/search/BaseSearch.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function searchByURL has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    searchByURL(url: string): Array<SearchResult> {
        const incomingDomain = extractDomain(url);
        if (!incomingDomain) {
            this._results = [];
            return this._results;
Severity: Minor
Found in source/search/BaseSearch.ts - About 1 hr to fix

    Function results has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            const results = this._entries.reduce((output, entryItem) => {
                let bestScore = Infinity;
                const bestURL = entryItem.urls.reduce((best, next) => {
                    const thisDomain = extractDomain(next);
                    if (!thisDomain) return best;
    Severity: Minor
    Found in source/search/BaseSearch.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                      return 0;
      Severity: Major
      Found in source/search/BaseSearch.ts - About 30 mins to fix

        Function incrementScore has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            async incrementScore(vaultID: VaultID, entryID: EntryID, url: string) {
                const scoresRaw = await this._memory.getValue(`bcup_search_${vaultID}`);
                let vaultScore = {};
                if (scoresRaw) {
                    try {
        Severity: Minor
        Found in source/search/BaseSearch.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function prepare has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            async prepare() {
                this._entries = [];
                this._scores = {};
                for (const target of this._targets) {
                    // Get scores
        Severity: Minor
        Found in source/search/BaseSearch.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (a.score > b.score) {
                            return 1;
                        } else if (b.score > a.score) {
                            return -1;
                        }
        Severity: Minor
        Found in source/search/BaseSearch.ts and 1 other location - About 35 mins to fix
        source/core/VaultManager.ts on lines 325..329

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (a.domainScore > b.domainScore) {
                            return -1;
                        } else if (b.domainScore > a.domainScore) {
                            return 1;
                        }
        Severity: Minor
        Found in source/search/BaseSearch.ts and 1 other location - About 35 mins to fix
        source/io/formatB/history.ts on lines 49..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status