Sign upLogin

byt3bl33d3r/MITMf

View on GitHub
Star
core/servers/Kerberos.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function ParseMSKerbv5TCP has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

def ParseMSKerbv5TCP(Data):
    MsgType     = Data[21:22]
    EncType     = Data[43:44]
    MessageType = Data[32:33]
Severity: Minor
Found in core/servers/Kerberos.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ParseMSKerbv5UDP has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def ParseMSKerbv5UDP(Data):
    MsgType = Data[17:18]
    EncType = Data[39:40]

    if MsgType == "\x0a" and EncType == "\x17":
Severity: Minor
Found in core/servers/Kerberos.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return False
Severity: Major
Found in core/servers/Kerberos.py - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status