byt3bl33d3r/MITMf

View on GitHub
plugins/browsersniper.py

Summary

Maintainability
C
1 day
Test Coverage

Function getExploits has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def getExploits(self):
        exploits = []
        vic_ip = self.output['ip']
        os = self.output['ua_name']
        browser = self.output['os_name']
Severity: Minor
Found in plugins/browsersniper.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function snipe has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def snipe(self):
        while True:
            if self.output:
                vic_ip = self.output['ip']

Severity: Minor
Found in plugins/browsersniper.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if (java is not None) and (java in details['PluginVersions']):
                            exploits.append(exploit)

Severity: Major
Found in plugins/browsersniper.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if (flash is not None) and (flash in details['PluginVersions']):
                                exploits.append(exploit)
    
    
    Severity: Major
    Found in plugins/browsersniper.py - About 45 mins to fix

      Function _compat_system has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def _compat_system(self, os_config, brw_config, os, browser):
      
              if (os_config == 'any') and (brw_config == 'any'):
                  return True
      
      
      Severity: Minor
      Found in plugins/browsersniper.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              for exploit in exploits:
      
                                  jobs = self.msf.findjobs(exploit)
                                  if jobs:
                                      self.log.info('{} => {} already started'.format(vic_ip, exploit))
      Severity: Major
      Found in plugins/browsersniper.py - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                return False
        Severity: Major
        Found in plugins/browsersniper.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              elif details['Plugin'].lower() == 'flash':
                                  
                                  if (flash is not None) and (flash in details['PluginVersions']):
                                      exploits.append(exploit)
          Severity: Minor
          Found in plugins/browsersniper.py and 1 other location - About 50 mins to fix
          plugins/browsersniper.py on lines 111..113

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if details['Plugin'].lower() == 'java':
                                  if (java is not None) and (java in details['PluginVersions']):
                                      exploits.append(exploit)
          Severity: Minor
          Found in plugins/browsersniper.py and 1 other location - About 50 mins to fix
          plugins/browsersniper.py on lines 115..118

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status