Sign upLogin

caffeinery/coffea

View on GitHub
Star

Showing 81 of 81 total issues

Function exports has 184 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {
    return function (irc) {
        irc.whoisCallbacks = {};

        /**
Severity: Major
Found in lib/plugins/whois.js - About 7 hrs to fix

    Function exports has 144 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function () {
    return function (irc) {
        /**
         * Catch all numerics registered in the IRC RFCs.
         * We are aware RFC recommendation is that 005 is RPL_BOUNCE
    Severity: Major
    Found in lib/plugins/numeric.js - About 5 hrs to fix

      Function exports has 137 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function () {
    return function (irc) {
        irc.mode = function ircMode(target, flags, network, fn) {
            var parse = utils.parseTarget(target);
            if (!network) { network = parse.network; }
      Severity: Major
      Found in lib/plugins/mode.js - About 5 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    case 'ERR_NOSUCHSERVER':
                params = msg.params.split(' ');
                target = params[1];
                cb = irc.whoisCallbacks[network + '_' + target];
                if (!cb) {
        Severity: Major
        Found in lib/plugins/whois.js and 1 other location - About 4 hrs to fix
        lib/plugins/whois.js on lines 220..232

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    case 'ERR_NOSUCHNICK':
                params = msg.params.split(' ');
                target = params[1];
                cb = irc.whoisCallbacks[network + '_' + target];
                if (!cb) {
        Severity: Major
        Found in lib/plugins/whois.js and 1 other location - About 4 hrs to fix
        lib/plugins/whois.js on lines 207..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function () {
    return function (irc) {
        irc.send = function ircSend(target, msg, network, fn) {
            // if network is the callback, then it wasn't defined either
            // we usually don't need this in every function because client.write does it
        Severity: Minor
        Found in lib/plugins/privmsg.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function () {
    return function (irc) {
        irc.send = function ircSend(target, msg, network, fn) {
            // if network is the callback, then it wasn't defined either
            // we usually don't need this in every function because client.write does it
        Severity: Major
        Found in lib/plugins/privmsg.js - About 3 hrs to fix

          Function exports has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function () {
    return function (irc) {
        irc.join = function ircJoin(channels, keys, network, fn) {
            if (typeof keys === 'function') { // join(channels, fn)
                fn = keys;
          Severity: Minor
          Found in lib/plugins/join.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 71 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function () {
    var userCache = [];
    return function (irc) {

        irc.getUser = function (nick, network) {
          Severity: Major
          Found in lib/plugins/user.js - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                utils.emit(irc, network, 'topic', {
                        "channel": chan,
                        "topic": chan.topic.topic,
                        "user": chan.topic.user,
                        "time": chan.topic.time,
            Severity: Major
            Found in lib/plugins/topic.js and 1 other location - About 2 hrs to fix
            lib/plugins/topic.js on lines 52..60

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                utils.emit(irc, network, 'topic', {
                        "channel": channel,
                        "topic": channel.topic.topic,
                        "user": channel.topic.user,
                        "time": channel.topic.time,
            Severity: Major
            Found in lib/plugins/topic.js and 1 other location - About 2 hrs to fix
            lib/plugins/topic.js on lines 37..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function exports has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function () {
    return function (irc) {
        irc.identify = function (username, password, network, fn) {
            if (typeof network === 'function') {
              fn = network;
            Severity: Minor
            Found in lib/plugins/nickserv.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function () {
    return function (irc) {
        irc.mode = function ircMode(target, flags, network, fn) {
            var parse = utils.parseTarget(target);
            if (!network) { network = parse.network; }
            Severity: Minor
            Found in lib/plugins/mode.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function () {
    return function (irc) {
        /**
         * 005 RPL_ISUPPORT Support for coffea.
         *
            Severity: Minor
            Found in lib/plugins/005.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function add has 55 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Client.prototype.add = function (info) {
    var stream, stream_id, streams = [];
    var _this = this;
    if (info instanceof Array) {
        // We've been passed multiple server information
            Severity: Major
            Found in index.js - About 2 hrs to fix

              Function exports has 53 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function () {
    return function (irc) {
        /**
         * Fetch names for `channel` and invoke `fn(err, names)`.
         *
              Severity: Major
              Found in lib/plugins/names.js - About 2 hrs to fix

                Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function () {
    return function (irc) {
        irc.topic = function ircTopic(channel, topic, network, fn) {
            var parse = utils.parseTarget(channel);
            if (!network) { network = parse.network; }
                Severity: Major
                Found in lib/plugins/topic.js - About 2 hrs to fix

                  Function exports has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = function () {
    return function (irc) {
        /**
         * Fetch names for `channel` and invoke `fn(err, names)`.
         *
                  Severity: Minor
                  Found in lib/plugins/names.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exports has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = function () {
    return function (irc) {
        irc.on('data', function (err, msg) {
            var network = msg.network;
            if (msg.command === 'ACCOUNT') {
                  Severity: Minor
                  Found in lib/plugins/cap-account-notify.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _check has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                  Client.prototype._check = function (network) {
    var ret = {};
    var randnick = "coffea"+Math.floor(Math.random() * 100000);

    if (typeof network === 'string') {
                  Severity: Minor
                  Found in index.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language