Sign upLogin

calonso/ruby-push-notifications

View on GitHub
Star
lib/ruby-push-notifications/wns/wns_notification.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method as_wns_xml has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def as_wns_xml
        xml = Builder::XmlMarkup.new
        xml.instruct!
        if data[:type] != :raw
          case data[:type]
Severity: Minor
Found in lib/ruby-push-notifications/wns/wns_notification.rb - About 1 hr to fix

    Method build_hash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def build_hash(xml, options)
        return unless options
        options.each do |k, v|
          xml.tag!(k.to_s) { v.is_a?(Hash) ? build_hash(xml, v) : xml.text!(v.to_s) }
        end
    Severity: Minor
    Found in lib/ruby-push-notifications/wns/wns_notification.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method as_wns_xml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def as_wns_xml
        xml = Builder::XmlMarkup.new
        xml.instruct!
        if data[:type] != :raw
          case data[:type]
    Severity: Minor
    Found in lib/ruby-push-notifications/wns/wns_notification.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status