Sign upLogin

carrierwaveuploader/carrierwave

View on GitHub
Star
lib/carrierwave/mounter.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Mounter has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Mounter # :nodoc:
    class Single < Mounter # :nodoc
      def identifier
        uploaders.first&.identifier
      end
Severity: Minor
Found in lib/carrierwave/mounter.rb - About 3 hrs to fix

    Method cache has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def cache(new_files)
      return if !new_files.is_a?(Array) && new_files.blank?
      old_uploaders = uploaders
      @uploaders = new_files.map do |new_file|
        handle_error do
    Severity: Minor
    Found in lib/carrierwave/mounter.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handle_error has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def handle_error
      yield
    rescue CarrierWave::DownloadError => e
      @download_errors << e
      raise e unless option(:ignore_download_errors)
    Severity: Minor
    Found in lib/carrierwave/mounter.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method cache has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def cache(new_files)
      return if !new_files.is_a?(Array) && new_files.blank?
      old_uploaders = uploaders
      @uploaders = new_files.map do |new_file|
        handle_error do
    Severity: Minor
    Found in lib/carrierwave/mounter.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status