Sign upLogin

carrierwaveuploader/carrierwave

View on GitHub
Star
lib/carrierwave/sanitized_file.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class SanitizedFile has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class SanitizedFile
    include CarrierWave::Utilities::FileName

    attr_reader :file
Severity: Minor
Found in lib/carrierwave/sanitized_file.rb - About 3 hrs to fix

    Method read has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def read(*args)
      if @content
        if args.empty?
          @content
        else
    Severity: Minor
    Found in lib/carrierwave/sanitized_file.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method size has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def size
      if is_path?
        exists? ? File.size(path) : 0
      elsif @file.respond_to?(:size)
        @file.size
    Severity: Minor
    Found in lib/carrierwave/sanitized_file.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method identified_content_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def identified_content_type
      with_io do |io|
        mimetype_by_magic = Marcel::Magic.by_magic(io)
        mimetype_by_path = Marcel::Magic.by_path(path)
    Severity: Minor
    Found in lib/carrierwave/sanitized_file.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

          if file.is_a?(Hash)
        @file = file["tempfile"] || file[:tempfile]
        @original_filename = file["filename"] || file[:filename]
        @declared_content_type = file["content_type"] || file[:content_type] || file["type"] || file[:type]
      else
    Severity: Major
    Found in lib/carrierwave/sanitized_file.rb - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status