caskdata/cdap_cookbook

View on GitHub

Showing 195 of 195 total issues

Assignment Branch Condition size for cdap_ssl? is too high. [37.67/15]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [13/10]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for cdap_jks_opts is too high. [18.71/15]
Open

    def cdap_jks_opts(prefix)
      ssl = {}
      ssl['password'] = node['cdap']['cdap_security']["#{prefix}.ssl.keystore.password"]
      ssl['keypass'] =
        if cdap_property?("#{prefix}.ssl.keystore.keypassword")
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for cdap_ssl? is too high. [8/6]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for cdap_ssl? is too high. [9/7]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [11/10]
Open

    def cdap_jks_opts(prefix)
      ssl = {}
      ssl['password'] = node['cdap']['cdap_security']["#{prefix}.ssl.keystore.password"]
      ssl['keypass'] =
        if cdap_property?("#{prefix}.ssl.keystore.keypassword")
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Ensure maintainer is set in metadata
Open

name 'cdap_test'

Ensure maintainer_email is set in metadata
Open

name 'cdap_test'

Method cdap_ssl? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

execute 'copy logback.xml from conf.dist' do
  command "cp -f /etc/cdap/conf.dist/logback.xml /etc/cdap/#{node['cdap']['conf_dir']}"
  not_if { ::File.exist?("/etc/cdap/#{node['cdap']['conf_dir']}/logback.xml") }
Severity: Minor
Found in recipes/config.rb and 1 other location - About 25 mins to fix
recipes/config.rb on lines 78..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 24.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

execute 'copy logback-container.xml from conf.dist' do
  command "cp /etc/cdap/conf.dist/logback-container.xml /etc/cdap/#{node['cdap']['conf_dir']}"
  not_if { ::File.exist?("/etc/cdap/#{node['cdap']['conf_dir']}/logback-container.xml") }
Severity: Minor
Found in recipes/config.rb and 1 other location - About 25 mins to fix
recipes/config.rb on lines 73..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 24.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  default['nodejs']['install_method'] = 'binary'
  default['nodejs']['version'] = '10.16.2'
  default['nodejs']['binary']['checksum']['linux_x64'] = nil
Severity: Minor
Found in attributes/sdk.rb and 2 other locations - About 20 mins to fix
attributes/sdk.rb on lines 158..160
attributes/sdk.rb on lines 162..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 23.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  default['nodejs']['install_method'] = 'binary'
  default['nodejs']['version'] = '4.5.0'
  default['nodejs']['binary']['checksum']['linux_x64'] = nil
Severity: Minor
Found in attributes/sdk.rb and 2 other locations - About 20 mins to fix
attributes/sdk.rb on lines 154..156
attributes/sdk.rb on lines 158..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 23.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  default['nodejs']['install_method'] = 'binary'
  default['nodejs']['version'] = '8.7.0'
  default['nodejs']['binary']['checksum']['linux_x64'] = nil
Severity: Minor
Found in attributes/sdk.rb and 2 other locations - About 20 mins to fix
attributes/sdk.rb on lines 154..156
attributes/sdk.rb on lines 162..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 23.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

template '/etc/init.d/cdap-router' do
  source 'cdap-service.erb'
  mode '0755'
  owner 'root'
  group 'root'
Severity: Minor
Found in recipes/router.rb and 4 other locations - About 15 mins to fix
recipes/kafka.rb on lines 52..58
recipes/master.rb on lines 80..86
recipes/security.rb on lines 29..35
recipes/ui.rb on lines 39..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

template '/etc/init.d/cdap-ui' do
  source 'cdap-service.erb'
  mode '0755'
  owner 'root'
  group 'root'
Severity: Minor
Found in recipes/ui.rb and 4 other locations - About 15 mins to fix
recipes/kafka.rb on lines 52..58
recipes/master.rb on lines 80..86
recipes/router.rb on lines 29..35
recipes/security.rb on lines 29..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

template '/etc/init.d/cdap-master' do
  source 'cdap-service.erb'
  mode '0755'
  owner 'root'
  group 'root'
Severity: Minor
Found in recipes/master.rb and 4 other locations - About 15 mins to fix
recipes/kafka.rb on lines 52..58
recipes/router.rb on lines 29..35
recipes/security.rb on lines 29..35
recipes/ui.rb on lines 39..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

template '/etc/init.d/cdap-auth-server' do
  source 'cdap-service.erb'
  mode '0755'
  owner 'root'
  group 'root'
Severity: Minor
Found in recipes/security.rb and 4 other locations - About 15 mins to fix
recipes/kafka.rb on lines 52..58
recipes/master.rb on lines 80..86
recipes/router.rb on lines 29..35
recipes/ui.rb on lines 39..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

template '/etc/init.d/cdap-kafka-server' do
  source 'cdap-service.erb'
  mode '0755'
  owner 'root'
  group 'root'
Severity: Minor
Found in recipes/kafka.rb and 4 other locations - About 15 mins to fix
recipes/master.rb on lines 80..86
recipes/router.rb on lines 29..35
recipes/security.rb on lines 29..35
recipes/ui.rb on lines 39..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    unless arr.include?(user)
      arr += [user]
      default['hadoop']['container_executor']['allowed.system.users'] = arr.join(',')
Severity: Minor
Found in attributes/security.rb and 1 other location - About 15 mins to fix
attributes/security.rb on lines 97..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language