caskdata/cdap_cookbook

View on GitHub
libraries/helpers.rb

Summary

Maintainability
A
25 mins
Test Coverage

Assignment Branch Condition size for cdap_ssl? is too high. [37.67/15]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [13/10]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for cdap_jks_opts is too high. [18.71/15]
Open

    def cdap_jks_opts(prefix)
      ssl = {}
      ssl['password'] = node['cdap']['cdap_security']["#{prefix}.ssl.keystore.password"]
      ssl['keypass'] =
        if cdap_property?("#{prefix}.ssl.keystore.keypassword")
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for cdap_ssl? is too high. [8/6]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for cdap_ssl? is too high. [9/7]
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [11/10]
Open

    def cdap_jks_opts(prefix)
      ssl = {}
      ssl['password'] = node['cdap']['cdap_security']["#{prefix}.ssl.keystore.password"]
      ssl['keypass'] =
        if cdap_property?("#{prefix}.ssl.keystore.keypassword")
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method cdap_ssl? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def cdap_ssl?
      ssl_enabled =
        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
          node['cdap']['cdap_site']['security.server.ssl.enabled']
        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line is too long. [81/80]
Open

                     node['cdap']['cdap_site']['security.enabled'].to_s == 'true'
Severity: Minor
Found in libraries/helpers.rb by rubocop

Missing top-level module documentation comment.
Open

  module Helpers
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [89/80]
Open

      return true if node['cdap'].key?(sitefile) && node['cdap'][sitefile].key?(property)
Severity: Minor
Found in libraries/helpers.rb by rubocop

Line is too long. [88/80]
Open

      ssl['password'] = node['cdap']['cdap_security']["#{prefix}.ssl.keystore.password"]
Severity: Minor
Found in libraries/helpers.rb by rubocop

Line is too long. [81/80]
Open

        elsif node['cdap']['version'].to_f < 4.0 && cdap_property?('ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

Line is too long. [94/80]
Open

        if node['cdap']['version'].to_f < 2.5 && cdap_property?('security.server.ssl.enabled')
Severity: Minor
Found in libraries/helpers.rb by rubocop

Use only ascii symbols in comments.
Open

# Copyright © 2016-2017 Cask Data, Inc.
Severity: Minor
Found in libraries/helpers.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

There are no issues that match your filters.

Category
Status