Sign upLogin

cea-sec/miasm

View on GitHub
Star
example/disasm/full.py

Summary

Maintainability
C
7 hrs
Test Coverage

File full.py has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import print_function
import logging
from argparse import ArgumentParser
from pdb import pm
Severity: Minor
Found in example/disasm/full.py - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                    for dest in instr.getdstflow(mdis.loc_db):
                    if not dest.is_loc():
                        continue
                    offset = mdis.loc_db.get_location_offset(dest.loc_key)
                    todo.append((mdis, instr, offset))
    Severity: Major
    Found in example/disasm/full.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if not instr:
                    continue
                for dest in instr.getdstflow(mdis.loc_db):
      Severity: Major
      Found in example/disasm/full.py - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    for assignblk in assignblks:
                dct = dict(assignblk)
                dct = {
                    dst:src for (dst, src) in viewitems(dct) if dst != self.sp
                }
        Severity: Major
        Found in example/disasm/full.py and 1 other location - About 3 hrs to fix
        example/ida/graph_ir.py on lines 205..210

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def is_addr_ro_variable(bs, addr, size):
        """
        Return True if address at @addr is a read-only variable.
        WARNING: Quick & Dirty
        Severity: Major
        Found in example/disasm/full.py and 1 other location - About 1 hr to fix
        example/ida/graph_ir.py on lines 165..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 42.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status