Sign upLogin

cellog/react-selection

View on GitHub
Star

Showing 19 of 37 total issues

Function makeSelectable has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

function makeSelectable(Component) {
  // always force a ReferenceableContainer if a stateless functional component is passed in
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
Severity: Minor
Found in src/Selection.jsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeSelectable has 195 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function makeSelectable(Component) {
  // always force a ReferenceableContainer if a stateless functional component is passed in
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
Severity: Major
Found in src/Selection.jsx - About 7 hrs to fix

    Function Selectable has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Selectable(Component, options) {
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
  let ReferenceableContainer
    Severity: Major
    Found in src/Selectable.jsx - About 3 hrs to fix

      Function Selectable has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

      function Selectable(Component, options) {
  const useContainer = verifyComponent(Component)
  const componentDisplayName = Component.displayName || Component.name || 'Component'
  let displayName
  let ReferenceableContainer
      Severity: Minor
      Found in src/Selectable.jsx - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function constructor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor() {
    const self = this
    this.accessor = {
      nodes() {
        return [...self.nodes]
      Severity: Minor
      Found in src/selectedList.js - About 1 hr to fix

        Function selectItemsInRectangle has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          selectItemsInRectangle(selectionRectangle, props, findit = findDOMNode, mouse = mouseMath) {
    if (!this.transaction.previousSelection) {
      // fail-safe
      this.begin([])
    }
        Severity: Minor
        Found in src/selectedList.js - About 1 hr to fix

          Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function (config, extraoptions) {
  config.set({

    basePath: '',
          Severity: Minor
          Found in karma-common.conf.js - About 1 hr to fix

            Function addItem has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              addItem(idx, selectedIndices = this.selectedIndices) {
    if (!this.transaction.firstNode) {
      this.transaction.firstNode = this.nodes[idx]
    }
    const si = selectedIndices
            Severity: Minor
            Found in src/selectedList.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function addItem has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              addItem(idx, selectedIndices = this.selectedIndices) {
    if (!this.transaction.firstNode) {
      this.transaction.firstNode = this.nodes[idx]
    }
    const si = selectedIndices
            Severity: Minor
            Found in src/selectedList.js - About 1 hr to fix

              Function shallowEqualScalar has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              export default function shallowEqualScalar(objA, objB) {
  if (objA === objB) {
    return true
  }
              Severity: Minor
              Found in src/shallowEqualScalar.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getCoordinates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                static getCoordinates(e, id, con = console) {
    if (!e.touches && e.clientX) {
      return {
        clientX: e.clientX,
        clientY: e.clientY,
              Severity: Minor
              Found in src/mouseMath.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getCoordinates has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static getCoordinates(e, id, con = console) {
    if (!e.touches && e.clientX) {
      return {
        clientX: e.clientX,
        clientY: e.clientY,
              Severity: Minor
              Found in src/mouseMath.js - About 1 hr to fix

                Function selectItemsInRectangle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  selectItemsInRectangle(selectionRectangle, props, findit = findDOMNode, mouse = mouseMath) {
    if (!this.transaction.previousSelection) {
      // fail-safe
      this.begin([])
    }
                Severity: Minor
                Found in src/selectedList.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function pageOffset has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  static pageOffset(dir, useLocal = false, win = window) {
    if (dir !== 'left' && dir !== 'top') {
      throw new Error(`direction must be one of top or left, was "${dir}"`)
    }
    const offsetname = dir === 'left' ? 'pageXOffset' : 'pageYOffset'
                Severity: Minor
                Found in src/mouseMath.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function selectItem has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  selectItem(idx) {
    // first check to see if this index is the same type as the first node selected
    const node = this.nodes[idx]
    if (!node.selectable) return
    if (this.props.hasOwnProperty('acceptedTypes')) {
                Severity: Minor
                Found in src/selectedList.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                  return true
                Severity: Major
                Found in src/shallowEqualScalar.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return false
                  Severity: Major
                  Found in src/shallowEqualScalar.js - About 30 mins to fix

                    Function shallowEqual has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export default function shallowEqual(objA, objB) {
  if (objA === objB) {
    return true
  }
                    Severity: Minor
                    Found in src/shallowEqual.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function testNodes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      testNodes({ selectionRectangle, props, findit, mouse }, node, idx) {
    let bounds
    if (node.bounds) {
      bounds = node.bounds
    } else {
                    Severity: Minor
                    Found in src/selectedList.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language