Sign upLogin

cequel/cequel

View on GitHub
Star

Showing 473 of 473 total issues

Use alias instead of alias_method in a class body.
Open

      alias_method :timestamp, :writetime
Severity: Minor
Found in lib/cequel/metal/row.rb by rubocop

This cop enforces the use of either #alias or #alias_method depending on configuration. It also flags uses of alias :symbol rather than alias bareword.

Example: EnforcedStyle: prefer_alias (default)

# bad
alias_method :bar, :foo
alias :bar :foo

# good
alias bar foo

Example: EnforcedStyle: preferaliasmethod

# bad
alias :bar :foo
alias bar foo

# good
alias_method :bar, :foo

Unnecessary utf-8 encoding comment.
Open

# -*- encoding : utf-8 -*-
Severity: Minor
Found in lib/cequel/metal/row.rb by rubocop

Unnecessary utf-8 encoding comment.
Open

# -*- encoding : utf-8 -*-
Severity: Minor
Found in lib/cequel/metal/writer.rb by rubocop

Line is too long. [93/80]
Open

          @statements.each { |s| statement.add(s.prepare(keyspace), arguments: s.bind_vars) }
Severity: Minor
Found in lib/cequel/metal/batch.rb by rubocop

Add an empty line after magic comments.
Open

module Cequel
Severity: Minor
Found in lib/cequel/metal/statement.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Do not use parallel assignment.
Open

        @column, @value = column, value
Severity: Minor
Found in lib/cequel/metal/row_specification.rb by rubocop

Checks for simple usages of parallel assignment. This will only complain when the number of variables being assigned matched the number of assigning variables.

Example:

# bad
a, b, c = 1, 2, 3
a, b, c = [1, 2, 3]

# good
one, two = *foo
a, b = foo()
a, b = b, a

a = 1
b = 2
c = 3

Align .append with .new on line 654.
Open

          .append(limit_cql)
Severity: Minor
Found in lib/cequel/metal/data_set.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

Align .append with .new on line 654.
Open

          .append(select_cql)
Severity: Minor
Found in lib/cequel/metal/data_set.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

Use alias instead of alias_method in a class body.
Open

      alias_method :decr, :decrement
Severity: Minor
Found in lib/cequel/metal/data_set.rb by rubocop

This cop enforces the use of either #alias or #alias_method depending on configuration. It also flags uses of alias :symbol rather than alias bareword.

Example: EnforcedStyle: prefer_alias (default)

# bad
alias_method :bar, :foo
alias :bar :foo

# good
alias bar foo

Example: EnforcedStyle: preferaliasmethod

# bad
alias :bar :foo
alias bar foo

# good
alias_method :bar, :foo

Add an empty line after magic comments.
Open

begin
Severity: Minor
Found in lib/cequel/metal/new_relic_instrumentation.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Extra blank line detected.
Open


      included do
Severity: Minor
Found in lib/cequel/metal/new_relic_instrumentation.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Avoid when branches without a body.
Open

        when "batch"
Severity: Minor
Found in lib/cequel/metal/new_relic_instrumentation.rb by rubocop

This cop checks for the presence of when branches without a body.

Example:

# bad

case foo
when bar then 1
when baz then # nothing
end

Example:

# good

case foo
when bar then 1
when baz then 2
end

Missing top-level class documentation comment.
Open

        class ClearAndRetryPolicy < ErrorPolicyBase
Severity: Minor
Found in lib/cequel/metal/policy/cassandra_error.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [120/80]
Open

  log_path = File.expand_path("../spec/log/#{Time.now.to_i}-#{version}-#{File.basename(gemfile, '.gemfile')}", __FILE__)
Severity: Minor
Found in Rakefile by rubocop

Line is too long. [113/80]
Open

            statement.statements.each { |s| batch_stmt << "\n" << sanitize(s.cql, limit_value_length(s.params)) }
Severity: Minor
Found in lib/cequel/metal/request_logger.rb by rubocop

Line is too long. [96/80]
Open

            raise NotImplementedError, "#execute_stmt must be implemented in #{self.class.name}"
Severity: Minor
Found in lib/cequel/metal/policy/cassandra_error.rb by rubocop

Line is too long. [81/80]
Open

  if File.read('./CHANGELOG.md').each_line.first.strip != "## #{Cequel::VERSION}"
Severity: Minor
Found in Rakefile by rubocop

Line is too long. [105/80]
Open

              raise ArgumentError, "The value for retry must be a positive number, not '#{@retry_delay}'"
Severity: Minor
Found in lib/cequel/metal/policy/cassandra_error.rb by rubocop

Add an empty line after magic comments.
Open

require 'stringio'
Severity: Minor
Found in lib/cequel/metal/batch.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

unexpected token tLT (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
Open

  <%- end -%>
Severity: Minor
Found in templates/record.rb by rubocop
Severity
Category
Status
Source
Language