cforlando/orlando-walking-tours-ios

View on GitHub
Orlando Walking Tours/Services/SocrataDataService.swift

Summary

Maintainability
D
2 days
Test Coverage

Function getLocations has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

    func getLocations(completion: @escaping (_ locations: [HistoricLocation]) -> Void)
    {
        var locations = [HistoricLocation]()

        Alamofire.request(locationsUrlString).validate().responseJSON
Severity: Minor
Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLocations has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func getLocations(completion: @escaping (_ locations: [HistoricLocation]) -> Void)
    {
        var locations = [HistoricLocation]()

        Alamofire.request(locationsUrlString).validate().responseJSON
Severity: Major
Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                if let title = subJson["name"].string
                                {
                                    location.locationTitle = title
                                }
    Severity: Major
    Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if let locationType = subJson["type"].string
                                  {
                                      location.locationType = locationType
                                  }
      Severity: Major
      Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if let nrhpDate = subJson["nhrp"].string
                                    {
                                        location.nrhpDate = DateFormatter().date(from: nrhpDate) as NSDate?
                                    }
        Severity: Major
        Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if let latitude = subJson["location"]["coordinates"][1].double
                                      {
                                          location.latitude = NSNumber(value: latitude)
                                      }
          Severity: Major
          Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if let address = subJson["address"].string
                                        {
                                            location.address = address
                                        }
            Severity: Major
            Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if let description = subJson["downtown_walking_tour"].string
                                          {
                                              location.locationDescription = description
                                          }
              Severity: Major
              Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if let longitude = subJson["location"]["coordinates"][0].double
                                            {
                                                location.longitude = NSNumber(value: longitude)
                                            }
                Severity: Major
                Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if let id = subJson["id"].string
                                              {
                                                  location.id = NumberFormatter().number(from: id)
                                              }
                  Severity: Major
                  Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if let localRegistryDate = subJson["local"].string
                                                {
                                                    location.localRegistryDate = DateFormatter().date(from: localRegistryDate) as NSDate?
                                                }
                    Severity: Major
                    Found in Orlando Walking Tours/Services/SocrataDataService.swift - About 45 mins to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          func getPhotos(for location: HistoricLocation, at path: String, completion: ([UIImage]?) -> Void)
                          {
                              completion(nil)
                          }
                      Severity: Minor
                      Found in Orlando Walking Tours/Services/SocrataDataService.swift and 1 other location - About 35 mins to fix
                      Orlando Walking Tours/Services/FirebaseDataService.swift on lines 90..94

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  if let localRegistryDate = subJson["local"].string
                                                  {
                                                      location.localRegistryDate = DateFormatter().date(from: localRegistryDate) as NSDate?
                                                  }
                      Severity: Minor
                      Found in Orlando Walking Tours/Services/SocrataDataService.swift and 1 other location - About 35 mins to fix
                      Orlando Walking Tours/Services/SocrataDataService.swift on lines 76..79

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 46.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  if let nrhpDate = subJson["nhrp"].string
                                                  {
                                                      location.nrhpDate = DateFormatter().date(from: nrhpDate) as NSDate?
                                                  }
                      Severity: Minor
                      Found in Orlando Walking Tours/Services/SocrataDataService.swift and 1 other location - About 35 mins to fix
                      Orlando Walking Tours/Services/SocrataDataService.swift on lines 71..74

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 46.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  if let latitude = subJson["location"]["coordinates"][1].double
                                                  {
                                                      location.latitude = NSNumber(value: latitude)
                                                  }
                      Severity: Minor
                      Found in Orlando Walking Tours/Services/SocrataDataService.swift and 1 other location - About 35 mins to fix
                      Orlando Walking Tours/Services/SocrataDataService.swift on lines 61..64

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 43.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                                  if let longitude = subJson["location"]["coordinates"][0].double
                                                  {
                                                      location.longitude = NSNumber(value: longitude)
                                                  }
                      Severity: Minor
                      Found in Orlando Walking Tours/Services/SocrataDataService.swift and 1 other location - About 35 mins to fix
                      Orlando Walking Tours/Services/SocrataDataService.swift on lines 66..69

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 43.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status