public/main/admin/user_linking_requests.php
The method getData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$line[] = Display::url(
$iconRemove,
$urlRemove.$request['user_id']
);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Doc comment for parameter $status does not match actual variable name $hrm Open
Open
* @param int $status- Exclude checks
Multi-line function call not indented correctly; expected 16 spaces but found 20 Open
Open
$iconAccept,- Exclude checks
Multi-line function call not indented correctly; expected 16 spaces but found 20 Open
Open
$urlAccept.$request['user_id']- Exclude checks
Multi-line function call not indented correctly; expected 12 spaces but found 16 Open
Open
).- Exclude checks
Consider putting global function "getData" in a static class Open
Open
function getData(User $hrm, $status = HRM_REQUEST)- Exclude checks
Multi-line function call not indented correctly; expected 16 spaces but found 20 Open
Open
$iconAccept,- Exclude checks
Multi-line function call not indented correctly; expected 12 spaces but found 16 Open
Open
).- Exclude checks
Multi-line function call not indented correctly; expected 16 spaces but found 20 Open
Open
$urlAccept.$request['user_id']- Exclude checks