public/main/cron/hosting_total_size_limit.php
Avoid using undefined variables such as '$sizeLimit' which will lead to PHP notices. Open
Open
if ($totalSize > $sizeLimit) {- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$sizeLimit' which will lead to PHP notices. Open
Open
$log .= "Current total size of $totalSize MB is bigger than limit: $sizeLimit MB \n";- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Missing class import via use statement (line '57', column '23'). Open
Open
$writer = new Laminas\Config\Writer\PhpArray();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method isTotalPortalSizeBiggerThanLimit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$log .= "Total size not updated \n";
$totalSize = $hostingData['size'];
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Consider putting global function "calculateTotalPortalSize" in a static class Open
Open
function calculateTotalPortalSize($debug)- Exclude checks
Consider putting global function "isTotalPortalSizeBiggerThanLimit" in a static class Open
Open
function isTotalPortalSizeBiggerThanLimit($debug = true)- Exclude checks