The method createAnswersForm() has an NPath complexity of 648. The configured NPath complexity threshold is 200. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
Missing class import via use statement (line '50', column '27'). Open
$answer = new Answer($this->id);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '175', column '26'). Open
$objAnswer = new Answer($this->id);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method return_header uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$header .= '<th>'.get_lang('Elements list').'</th>';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method createAnswersForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$form->setDefaults(['orientation' => 'h']);
if (1 == $this->isContent) {
$form->setDefaults($defaults);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method createAnswersForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$nb_options++;
$defaults['option['.$nb_options.']'] = $answer->selectAnswer($i);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method createAnswersForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$defaults['answer[1]'] = get_lang('First step');
$defaults['answer[2]'] = get_lang('Second step');
$defaults['matches[2]'] = '2';
$defaults['option[1]'] = get_lang('Note down the address');- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
public function createAnswersForm($form)- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$nb_matches = $nb_options = 0;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$defaults['weighting['.$nb_matches.']'] = float_format($answer->selectWeighting($i), 1);- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$nb_matches = $nb_options = 2;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$defaults['answer['.$nb_matches.']'] = $answer->selectAnswer($i);- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$defaults['matches['.$nb_matches.']'] = isset($answerInfo['answer']) ? $answerInfo['answer'] : '';- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$nb_options = $form->getSubmitValue('nb_options');- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches--;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches = $nb_options = 2;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches = $nb_options = 0;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches++;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches++;- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$nb_options--;- Exclude checks
Missing function doc comment Open
public function __construct()- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches = $form->getSubmitValue('nb_matches');- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$nb_options++;- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$defaults['option['.$nb_options.']'] = $answer->selectAnswer($i);- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
for ($i = 1; $i <= $nb_matches; $i++) {- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches = 1;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
'nb_matches' => $nb_matches,- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
if ($nb_matches < 1) {- Exclude checks
Missing function doc comment Open
public function processAnswersCreation($form, $exercise)- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
for ($i = 1; $i <= $nb_matches; $i++) {- Exclude checks
Missing function doc comment Open
public function return_header(Exercise $exercise, $counter = null, $score = [])- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
for ($i = 1; $i <= $nb_matches; $i++) {- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
for ($i = 1; $i <= $nb_matches; $i++) {- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$nb_options++;- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$form->addElement('hidden', 'nb_matches', $nb_matches);- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
'nb_options' => $nb_options,- Exclude checks
Method name "Draggable::return_header" is not in camel caps format Open
public function return_header(Exercise $exercise, $counter = null, $score = [])- Exclude checks
Variable "nb_options" is not in valid camel caps format Open
$form->addElement('hidden', 'nb_options', $nb_options);- Exclude checks
Variable "nb_matches" is not in valid camel caps format Open
$nb_matches = $form->getSubmitValue('nb_matches');- Exclude checks
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function processAnswersCreation($form, $exercise)
{
$this->extra = $form->exportValue('orientation');
$nb_matches = $form->getSubmitValue('nb_matches');
$this->weighting = 0;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function processAnswersCreation($form, $exercise)
{
$this->extra = $form->exportValue('orientation');
$nb_matches = $form->getSubmitValue('nb_matches');
$this->weighting = 0;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function processAnswersCreation($form, $exercise)
{
$this->extra = $form->exportValue('orientation');
$nb_matches = $form->getSubmitValue('nb_matches');
$this->weighting = 0;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_matches is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $nb_options is not named in camelCase. Open
public function createAnswersForm($form)
{
$defaults = [];
$nb_matches = $nb_options = 2;
$matches = [];- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method return_header is not named in camelCase. Open
public function return_header(Exercise $exercise, $counter = null, $score = [])
{
$header = parent::return_header($exercise, $counter, $score);
$header .= '<table class="'.$this->questionTableClass.'"><tr>';
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}