public/main/exercise/ReadingComprehension.php
Missing class import via use statement (line '198', column '21'). Open
Open
$view = new Template('', false, false, false, true, false, false);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method createForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$form->addText('questionName', get_lang('Question'), false);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$exercise'. Open
Open
public function createForm(&$form, $exercise)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Missing function doc comment Open
Open
public function __construct()- Exclude checks
Missing function doc comment Open
Open
public static function get_default_levels()- Exclude checks
Missing function doc comment Open
Open
public function createForm(&$form, $exercise)- Exclude checks
Missing function doc comment Open
Open
public function processText($text)- Exclude checks
Method name "ReadingComprehension::get_default_levels" is not in camel caps format Open
Open
public static function get_default_levels()- Exclude checks
The method get_default_levels is not named in camelCase. Open
Open
public static function get_default_levels()
{
return [
1 => sprintf(get_lang('%s words per minute'), self::$speeds[1]),
2 => sprintf(get_lang('%s words per minute'), self::$speeds[2]),- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}