Avoid unused parameters such as '$exercise'. Open
public function processAnswersCreation($form, $exercise)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$form'. Open
public function processAnswersCreation($form, $exercise)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$form'. Open
public function createAnswersForm($form)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused local variables such as '$icon'. Open
$icon = Display::return_icon(- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method createForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
// setting the save button here and not in the question class.php
// Editing a question
$form->addButtonUpdate(get_lang('Save the question'), 'submitQuestion');
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing function doc comment Open
public function __construct()- Exclude checks
Missing function doc comment Open
public function createForm(&$form, $exercise)- Exclude checks
Method name "HotSpot::return_header" is not in camel caps format Open
public function return_header(Exercise $exercise, $counter = null, $score = [])- Exclude checks
Missing function doc comment Open
public static function getLangVariables()- Exclude checks
Missing function doc comment Open
public function processAnswersCreation($form, $exercise)- Exclude checks
Missing function doc comment Open
public function createAnswersForm($form)- Exclude checks
Missing function doc comment Open
public function processCreation($form, $exercise)- Exclude checks
Missing function doc comment Open
public function display()- Exclude checks
The method return_header is not named in camelCase. Open
public function return_header(Exercise $exercise, $counter = null, $score = [])
{
return parent::return_header($exercise, $counter, $score)
.'<table><tr><td><table class="table">';
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}