Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
public/main/exercise/question.class.php

Summary

Maintainability
A
0 mins
Test Coverage

The method createForm() has an NPath complexity of 112896. The configured NPath complexity threshold is 200.
Open

    public function createForm(&$form, $exercise)
    {
        $zoomOptions = api_get_setting('exercise.quiz_image_zoom', true);
        if (isset($zoomOptions['options'])) {
            $finderFolder = api_get_path(WEB_PATH).'vendor/studio-42/elfinder/';
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method return_header() has an NPath complexity of 2654208. The configured NPath complexity threshold is 200.
Open

    public function return_header(Exercise $exercise, $counter = null, $score = [])
    {
        $counterLabel = '';
        if (!empty($counter)) {
            $counterLabel = (int) $counter;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method read() has an NPath complexity of 684. The configured NPath complexity threshold is 200.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method search_engine_edit() has an NPath complexity of 7137. The configured NPath complexity threshold is 200.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using undefined variables such as '$speeds' which will lead to PHP notices.
Open

                        ReadingComprehension::$speeds[$this->level],
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$speeds' which will lead to PHP notices.
Open

                        ReadingComprehension::$speeds[$this->level],
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

The class Question has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13.
Open

abstract class Question
{
    public $id;
    public $iid;
    public $question;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Missing class import via use statement (line '682', column '27').
Open

                $di = new ChamiloIndexer();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1078', column '27').
Open

                throw new Exception('implement copy of hotspot question');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '722', column '33').
Open

                $ic_slide = new IndexableChunk();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1415', column '37').
Open

            $extraFieldValues = new ExtraFieldValue('question');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1363', column '27').
Open

        $extraField = new ExtraField('question');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '818', column '32').
Open

            $newExercise = new Exercise($courseId);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '1061', column '31').
Open

            $extraField = new ExtraFieldValue('question');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '958', column '31').
Open

            $extraField = new ExtraFieldValue('question');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method search_engine_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $sql = "DELETE FROM %S
                            WHERE
                                course_code = '%s'
                                AND tool_id = '%s'
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method removeFromList uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // deletes the position in the array containing the wanted exercise ID
            unset($this->exerciseList[$pos]);
            //update order of other elements
            $sql = "SELECT question_order
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method displayTypeMenu uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo $url = '<a href="question_pool.php?'.api_get_cidreq().'&fromExercise='.$exerciseId.'">';
            }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method search_engine_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                    } else {
                        $sql = "INSERT INTO %s (
                                id, course_code, tool_id, ref_id_high_level, ref_id_second_level, search_did
                            )
                            VALUES (
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method return_header uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $message = Display::div(
                    sprintf(
                        get_lang(
                            'Sorry, it seems like a speed of %s words/minute was too fast for this text of %s words.'
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid assigning values to variables in if clauses and the like (line '163', column '13').
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method delete uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // just removes the exercise from the list
            $this->removeFromList($deleteFromEx, $courseId);
            if ('true' == api_get_setting('search_enabled') && extension_loaded('xapian')) {
                // disassociate question with this exercise
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method return_header uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            /** @var ReadingComprehension $this */
            if (true === $score['pass']) {
                $message = Display::div(
                    sprintf(
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method search_engine_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $question_exercises = [];
                }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method return_header uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $scoreLabel = get_lang('Not reviewed');
                    $class = 'warning';
                    if (isset($score['weight'])) {
                        $weight = float_format($score['weight'], 1);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method show_media_content uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $html .= Display::page_subheader($this->selectTitle());
            $html .= $this->selectDescription();
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // Creates a new question
            $sql = "SELECT max(position)
                    FROM $TBL_QUESTIONS as question,
                    $TBL_EXERCISE_QUESTION as test_question
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method createForm uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $form->addText('questionName', get_lang('Question'));
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid assigning values to variables in if clauses and the like (line '695', column '36').
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method saveCategory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // update or add category for a question
            $table = Database::get_course_table(TABLE_QUIZ_QUESTION_REL_CATEGORY);
            $categoryId = (int) $categoryId;
            $questionId = (int) $this->id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method displayTypeMenu uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (in_array($feedbackType, [EXERCISE_FEEDBACK_TYPE_DIRECT, EXERCISE_FEEDBACK_TYPE_POPUP])) {
                echo $url = '<a href="question_pool.php?'.api_get_cidreq()."&type=1&fromExercise=$exerciseId\">";
            } else {
                echo $url = '<a href="question_pool.php?'.api_get_cidreq().'&fromExercise='.$exerciseId.'">';
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method saveCategory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $sql = "INSERT INTO $table (question_id, category_id)
                        VALUES ($questionId, $categoryId)
                        ";
                Database::query($sql);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method search_engine_edit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $sql = 'SELECT * FROM %s
                    WHERE course_code=\'%s\' AND tool_id=\'%s\'
                    AND ref_id_high_level=%s AND ref_id_second_level=%s LIMIT 1';
                $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method getInstance uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    echo 'Can\'t instanciate class '.$className.' of type '.$type;
                }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$where_condition'.
Open

        $where_condition = []
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused local variables such as '$url'.
Open

                echo $url = '<a href="question_pool.php?'.api_get_cidreq()."&type=1&fromExercise=$exerciseId\">";
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The parameter $quiz_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $question_description is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $course_id is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $course_info is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $course_id is not named in camelCase.
Open

    public static function get_count_course_medias($course_id)
    {
        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $result = Database::select(
            'count(*) as count',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $question_id is not named in camelCase.
Open

    public static function readQuestionOption($question_id)
    {
        $table = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);

        return Database::select(
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $category_list is not named in camelCase.
Open

abstract class Question
{
    public $id;
    public $iid;
    public $question;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $max_score is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $parent_id is not named in camelCase.
Open

abstract class Question
{
    public $id;
    public $iid;
    public $question;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $question_id is not named in camelCase.
Open

    public static function deleteAllQuestionOptions($question_id, $course_id)
    {
        $table = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);
        Database::delete(
            $table,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $question_name is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $where_condition is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $course_id is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $course_id is not named in camelCase.
Open

    public static function deleteAllQuestionOptions($question_id, $course_id)
    {
        $table = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);
        Database::delete(
            $table,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Variable "parent_id" is not in valid camel caps format
Open

        $this->parent_id = 0;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Missing function doc comment
Open

    public function getId()
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_info" is not in valid camel caps format
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_info" is not in valid camel caps format
Open

            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Abstract class name is not prefixed with "Abstract"
Open

abstract class Question
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_info" is not in valid camel caps format
Open

        $course_id = $course_info['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Member variable "parent_id" is not in valid camel caps format
Open

    public $parent_id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_info" is not in valid camel caps format
Open

        if (empty($course_info)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Member variable "category_list" is not in valid camel caps format
Open

    public $category_list;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        $course_id = $course_info['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "category_list" is not in valid camel caps format
Open

        $this->category_list = [];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        if (empty($course_id) || -1 == $course_id) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        if (empty($course_id) || -1 == $course_id) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                            SE_DOCTYPE_EXERCISE_QUESTION == $se_doc_data[SE_DATA]['type']
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "xapian_data" is not in valid camel caps format
Open

                $ic_slide->xapian_data = serialize($xapian_data);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                    $course_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $max_score does not match actual variable name $question_description
Open

     * @param int    $max_score            Maximum result for the question
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $level does not match actual variable name $type
Open

     * @param int    $level                Question level/category
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_position" is not in valid camel caps format
Open

        $max_position = $row_max->max_position + 1;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                $objQuestion->category = TestCategory::getCategoryForQuestion($id, $course_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTIONS" is not in valid camel caps format
Open

        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "current_position" is not in valid camel caps format
Open

            $this->updatePosition($current_position + 1);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                                array_shift($question_exercises),
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

                    FROM $TBL_EXERCISE_QUESTION
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

                        $sql = "UPDATE $TBL_EXERCISE_QUESTION
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTIONS" is not in valid camel caps format
Open

            $sql = "DELETE FROM $TBL_QUESTIONS
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        $courseEntity = api_get_course_entity($course_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

                        $question_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_description" is not in valid camel caps format
Open

        $question_description = '',
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_score" is not in valid camel caps format
Open

        $max_score = (float) $max_score;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

                            $objQuestion->exerciseList[] = $obj->quiz_id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "current_position" is not in valid camel caps format
Open

            $current_position = Database::result($result, 0, 0);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::search_engine_edit" is not in camel caps format
Open

    public function search_engine_edit(
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

                $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "old_value" is not in valid camel caps format
Open

                                        $question_exercises[] = $old_value;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $question_name does not match actual variable name $quiz_id
Open

     * @param int    $question_name        Quiz ID
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_rel_question" is not in valid camel caps format
Open

        $tbl_quiz_rel_question = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_description" is not in valid camel caps format
Open

            'description' => $question_description,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTIONS" is not in valid camel caps format
Open

                FROM $TBL_QUESTIONS
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                $categoryInfo = TestCategory::getCategoryInfoForQuestion($id, $course_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Missing function doc comment
Open

    public function setMandatory($value)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                        if (isset($se_doc_data[SE_DATA]['type']) &&
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "old_value" is not in valid camel caps format
Open

                                foreach ($se_doc_data[SE_DATA]['exercise_ids'] as $old_value) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                $ic_slide->addCourseId($course_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                    $item['c_id'] = $course_id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::get_question_type_name" is not in camel caps format
Open

    public function get_question_type_name()
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "results_disabled" is not in valid camel caps format
Open

            if (in_array($exercise->results_disabled, [
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "results_disabled" is not in valid camel caps format
Open

            if (in_array($exercise->results_disabled, [
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $type does not match actual variable name $max_score
Open

     * @param int    $type                 Type of question (see constants at beginning of question.class.php)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_rel_question" is not in valid camel caps format
Open

                INNER JOIN $tbl_quiz_rel_question r
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "row_max" is not in valid camel caps format
Open

        $row_max = Database::fetch_object($rs_max);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                    $question_exercises = [];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $ic_slide->addToolId(TOOL_QUIZ);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $ic_slide->xapian_data = serialize($xapian_data);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "xapian_data" is not in valid camel caps format
Open

                $ic_slide->xapian_data = serialize($xapian_data);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

                                $tbl_se_ref,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                        $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id, $did);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Use parentheses when instantiating classes
Open

            $type = new $type[1]();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_question" is not in valid camel caps format
Open

                FROM $tbl_quiz_question q
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

                    quiz_id = $quiz_id";
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

                            FROM $TBL_EXERCISE_QUESTION q
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

            $tbl_se_ref = Database::get_main_table(TABLE_MAIN_SEARCH_ENGINE_REF);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                        $se_doc_data = UnserializeApi::unserialize(
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

                        $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_REPONSES" is not in valid camel caps format
Open

            $sql = "DELETE FROM $TBL_REPONSES
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

        $quiz_id = (int) $quiz_id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "rs_max" is not in valid camel caps format
Open

        $rs_max = Database::query($sql);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_score" is not in valid camel caps format
Open

            'ponderation' => $max_score,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTIONS" is not in valid camel caps format
Open

        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

            $course_id = api_get_course_id();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

                $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc" is not in valid camel caps format
Open

                if (false !== $se_doc) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc" is not in valid camel caps format
Open

                    if (false !== ($se_doc_data = $di->get_document_data($se_doc))) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                                foreach ($se_doc_data[SE_DATA]['exercise_ids'] as $old_value) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_ref" is not in valid camel caps format
Open

                $di->remove_document($se_ref['search_did']);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                if (!empty($question_exercises)) { // if empty there is nothing to index
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "exercise_was_added_in_lp" is not in valid camel caps format
Open

                if (true == $objExercise->exercise_was_added_in_lp) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "exercise_was_added_in_lp" is not in valid camel caps format
Open

        if (true == $objExercise->exercise_was_added_in_lp) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "results_disabled" is not in valid camel caps format
Open

        if (in_array($exercise->results_disabled, [
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $quiz_id does not match actual variable name $level
Open

     * @param string $quiz_id
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

        $quiz_id = (int) $quiz_id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "rs_max" is not in valid camel caps format
Open

        $row_max = Database::fetch_object($rs_max);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                        WHERE c_id = $course_id AND question_id = ".(int) ($this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "old_value" is not in valid camel caps format
Open

                                    if (!in_array($old_value, $question_exercises)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTION_OPTIONS" is not in valid camel caps format
Open

        $TBL_QUESTION_OPTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_position" is not in valid camel caps format
Open

            'position' => $max_position,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        if (empty($course_id)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $position does not match actual variable name $name
Open

     * @param int    $position
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

    public static function deleteAllQuestionOptions($question_id, $course_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

    public static function readQuestionOption($question_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $counter does not match actual variable name $exercise
Open

     * @param int   $counter
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::create_question" is not in camel caps format
Open

    public function create_question(
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        $course_id = $this->course['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

            $course_id = api_get_course_int_id();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_ref" is not in valid camel caps format
Open

                $se_doc = $di->get_document((int) $se_ref['search_did']);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                            if (isset($se_doc_data[SE_DATA]['exercise_ids']) &&
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

                        $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                        $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTIONS" is not in valid camel caps format
Open

        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

            $sql = "DELETE FROM $TBL_EXERCISE_QUESTION
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

    public static function deleteAllQuestionOptions($question_id, $course_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

        $quiz_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                    $question_exercises = [(int) $exerciseId];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $ic_slide->addCourseId($course_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                        if (!empty($question_exercises)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUIZ_QUESTION_REL_CATEGORY" is not in valid camel caps format
Open

        $TBL_QUIZ_QUESTION_REL_CATEGORY = Database::get_course_table(TABLE_QUIZ_QUESTION_REL_CATEGORY);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTION_OPTIONS" is not in valid camel caps format
Open

                    Database::insert($TBL_QUESTION_OPTIONS, $item);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::get_question_type" is not in camel caps format
Open

    public static function get_question_type($type)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "force_edit_exercise_in_lp" is not in valid camel caps format
Open

            if (false === $objExercise->force_edit_exercise_in_lp) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_question" is not in valid camel caps format
Open

        $tbl_quiz_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

        $question_id = Database::insert($tbl_quiz_question, $params);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_question" is not in valid camel caps format
Open

        $question_id = Database::insert($tbl_quiz_question, $params);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

                    WHERE quiz_id = $quiz_id ";
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Missing function doc comment
Open

    public function getTitleToDisplay(Exercise $exercise, int $itemNumber): string
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "c_id" is not in valid camel caps format
Open

        $c_id = $this->course['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUESTIONS" is not in valid camel caps format
Open

                    FROM $TBL_QUESTIONS as question,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                    while (false !== ($key = array_search($exerciseId, $question_exercises))) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                        'exercise_ids' => $question_exercises,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $name does not match actual variable name $question
Open

     * @param string $name
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

                    $question_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::return_header" is not in camel caps format
Open

    public function return_header(Exercise $exercise, $counter = null, $score = [])
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $question_description does not match actual variable name $question_name
Open

     * @param string $question_description Question name
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

        if ($question_id) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "c_id" is not in valid camel caps format
Open

        $courseEntity = api_get_course_entity($c_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                            $se_doc_data
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                                    if (!in_array($old_value, $question_exercises)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                                        $question_exercises[] = $old_value;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $ic_slide = new IndexableChunk();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                        $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $this->id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "show_media" is not in valid camel caps format
Open

        $show_media = '';
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "row_max" is not in valid camel caps format
Open

        $max_position = $row_max->max_position + 1;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_info" is not in valid camel caps format
Open

                $objQuestion->course = $course_info;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc" is not in valid camel caps format
Open

                $se_doc = $di->get_document((int) $se_ref['search_did']);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $ic_slide->addValue('title', $this->question);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                    SE_COURSE_ID => $course_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "show_media" is not in valid camel caps format
Open

        if ($show_media) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_name" is not in valid camel caps format
Open

        $question_name,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_score" is not in valid camel caps format
Open

        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_score" is not in valid camel caps format
Open

        $max_score = (float) $max_score;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_position" is not in valid camel caps format
Open

        $max_position = $row_max->max_position + 1;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_EXERCISE_QUESTION" is not in valid camel caps format
Open

                    $TBL_EXERCISE_QUESTION as test_question
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_ref" is not in valid camel caps format
Open

                $se_ref = Database::fetch_array($res);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_exercises" is not in valid camel caps format
Open

                        unset($question_exercises[$key]);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "xapian_data" is not in valid camel caps format
Open

                $xapian_data = [
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                                $course_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_se_ref" is not in valid camel caps format
Open

                        $sql = sprintf($sql, $tbl_se_ref, $course_id, TOOL_QUIZ, $exerciseId, $this->id, $did);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_QUIZ_QUESTION_REL_CATEGORY" is not in valid camel caps format
Open

            $sql = "DELETE FROM $TBL_QUIZ_QUESTION_REL_CATEGORY
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        $course_id = $courseInfo['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                    if (false !== ($se_doc_data = $di->get_document_data($se_doc))) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "se_doc_data" is not in valid camel caps format
Open

                                is_array($se_doc_data[SE_DATA]['exercise_ids'])
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $ic_slide->addValue('content', $this->description);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "ic_slide" is not in valid camel caps format
Open

                $di->addChunk($ic_slide);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "TBL_REPONSES" is not in valid camel caps format
Open

        $TBL_REPONSES = Database::get_course_table(TABLE_QUIZ_ANSWER);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Doc comment for parameter $score does not match actual variable name $counter
Open

     * @param array $score
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "results_disabled" is not in valid camel caps format
Open

                if (in_array($exercise->results_disabled, [
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "display_category_name" is not in valid camel caps format
Open

        if ($exercise->display_category_name) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_name" is not in valid camel caps format
Open

            'question' => $question_name,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_rel_question" is not in valid camel caps format
Open

                    FROM $tbl_quiz_rel_question
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "tbl_quiz_rel_question" is not in valid camel caps format
Open

            $sql = "INSERT INTO $tbl_quiz_rel_question (question_id, quiz_id, question_order)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "media_list" is not in valid camel caps format
Open

        $media_list = [];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::get_default_levels" is not in camel caps format
Open

    public static function get_default_levels()
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "row_max_order" is not in valid camel caps format
Open

            $row_max_order = Database::fetch_object($rs_max_order);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "rs_max_order" is not in valid camel caps format
Open

            $rs_max_order = Database::query($sql);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_order" is not in valid camel caps format
Open

                    VALUES($question_id, $quiz_id, $max_order)";
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "media_list" is not in valid camel caps format
Open

                $media_list[$media['id']] = empty($media['question']) ? get_lang('Untitled') : $media['question'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "media_list" is not in valid camel caps format
Open

        return $media_list;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "table_question" is not in valid camel caps format
Open

        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                $course_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        $course_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

                    VALUES($question_id, $quiz_id, $max_order)";
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "quiz_id" is not in valid camel caps format
Open

                    VALUES($question_id, $quiz_id, $max_order)";
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "table_question" is not in valid camel caps format
Open

            $table_question,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

    public static function get_count_course_medias($course_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "parent_question" is not in valid camel caps format
Open

            $html = $parent_question->show_media_content();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Use parentheses when instantiating classes
Open

        $swappedAnswer = new $answerClasses[$this->type]();
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::prepare_course_media_select" is not in camel caps format
Open

    public static function prepare_course_media_select($course_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "media_list" is not in valid camel caps format
Open

        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "where_condition" is not in valid camel caps format
Open

        $where_condition = []
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "default_where" is not in valid camel caps format
Open

                'where' => $default_where,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::get_count_course_medias" is not in camel caps format
Open

    public static function get_count_course_medias($course_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "table_question" is not in valid camel caps format
Open

            $table_question,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::get_course_medias" is not in camel caps format
Open

    public static function get_course_medias(
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_order" is not in valid camel caps format
Open

            $max_order = $row_max_order->max_order + 1;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "question_id" is not in valid camel caps format
Open

        return $question_id;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "parent_question" is not in valid camel caps format
Open

            $parent_question = self::read($this->parent_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "rs_max_order" is not in valid camel caps format
Open

            $row_max_order = Database::fetch_object($rs_max_order);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "row_max_order" is not in valid camel caps format
Open

            $max_order = $row_max_order->max_order + 1;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

                        $course_id,
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

        $medias = self::get_course_medias($course_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Method name "Question::show_media_content" is not in camel caps format
Open

    public function show_media_content()
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "parent_id" is not in valid camel caps format
Open

        if (0 != $this->parent_id) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "max_order" is not in valid camel caps format
Open

            $max_order = $row_max_order->max_order + 1;
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

    public static function prepare_course_media_select($course_id)
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "parent_id" is not in valid camel caps format
Open

            $parent_question = self::read($this->parent_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "default_where" is not in valid camel caps format
Open

        $default_where = [
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

Variable "table_question" is not in valid camel caps format
Open

        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
Severity: Minor
Found in public/main/exercise/question.class.php by phpcodesniffer

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTIONS is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTIONS is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTION_OPTIONS is not named in camelCase.
Open

    public function duplicate($courseInfo = [])
    {
        $courseInfo = empty($courseInfo) ? $this->course : $courseInfo;

        if (empty($courseInfo)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function duplicate($courseInfo = [])
    {
        $courseInfo = empty($courseInfo) ? $this->course : $courseInfo;

        if (empty($courseInfo)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_score is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_position is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_order is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $media_list is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTIONS is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $c_id is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $xapian_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $table_question is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_where is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $current_position is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_value is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUIZ_QUESTION_REL_CATEGORY is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function duplicate($courseInfo = [])
    {
        $courseInfo = empty($courseInfo) ? $this->course : $courseInfo;

        if (empty($courseInfo)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function duplicate($courseInfo = [])
    {
        $courseInfo = empty($courseInfo) ? $this->course : $courseInfo;

        if (empty($courseInfo)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $row_max is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTIONS is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rs_max is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_value is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $show_media is not named in camelCase.
Open

    public function return_header(Exercise $exercise, $counter = null, $score = [])
    {
        $counterLabel = '';
        if (!empty($counter)) {
            $counterLabel = (int) $counter;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_description is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_rel_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function deleteAllQuestionOptions($question_id, $course_id)
    {
        $table = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);
        Database::delete(
            $table,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $quiz_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_position is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function get_count_course_medias($course_id)
    {
        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $result = Database::select(
            'count(*) as count',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $media_list is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_info is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_info is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_se_ref is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_REPONSES is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_id is not named in camelCase.
Open

    public static function readQuestionOption($question_id)
    {
        $table = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);

        return Database::select(
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_rel_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_rel_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_name is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_where is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $media_list is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_info is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTIONS is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_REPONSES is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $show_media is not named in camelCase.
Open

    public function return_header(Exercise $exercise, $counter = null, $score = [])
    {
        $counterLabel = '';
        if (!empty($counter)) {
            $counterLabel = (int) $counter;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_order is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $table_question is not named in camelCase.
Open

    public static function get_count_course_medias($course_id)
    {
        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $result = Database::select(
            'count(*) as count',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_question is not named in camelCase.
Open

    public function show_media_content()
    {
        $html = '';
        if (0 != $this->parent_id) {
            $parent_question = self::read($this->parent_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_id is not named in camelCase.
Open

    public static function deleteAllQuestionOptions($question_id, $course_id)
    {
        $table = Database::get_course_table(TABLE_QUIZ_QUESTION_OPTION);
        Database::delete(
            $table,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $quiz_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $quiz_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $row_max_order is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $row_max_order is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $table_question is not named in camelCase.
Open

    public static function get_count_course_medias($course_id)
    {
        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $result = Database::select(
            'count(*) as count',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_question is not named in camelCase.
Open

    public function show_media_content()
    {
        $html = '';
        if (0 != $this->parent_id) {
            $parent_question = self::read($this->parent_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUIZ_QUESTION_REL_CATEGORY is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_score is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rs_max is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function updateType($type)
    {
        $table = Database::get_course_table(TABLE_QUIZ_ANSWER);
        $course_id = $this->course['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $old_value is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $current_position is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTIONS is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rs_max_order is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $rs_max_order is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $xapian_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $quiz_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $table_question is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_info is not named in camelCase.
Open

    public static function read($id, $course_info = [], $getExerciseList = true)
    {
        $id = (int) $id;
        if (empty($course_info)) {
            $course_info = api_get_course_info();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function updateType($type)
    {
        $table = Database::get_course_table(TABLE_QUIZ_ANSWER);
        $course_id = $this->course['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $se_doc_data is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ic_slide is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_EXERCISE_QUESTION is not named in camelCase.
Open

    public function delete($deleteFromEx = 0)
    {
        if (empty($this->course)) {
            return false;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $max_score is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $tbl_quiz_rel_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $media_list is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function updateType($type)
    {
        $table = Database::get_course_table(TABLE_QUIZ_ANSWER);
        $course_id = $this->course['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function updateType($type)
    {
        $table = Database::get_course_table(TABLE_QUIZ_ANSWER);
        $course_id = $this->course['real_id'];
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $c_id is not named in camelCase.
Open

    public function save($exercise)
    {
        $TBL_EXERCISE_QUESTION = Database::get_course_table(TABLE_QUIZ_TEST_QUESTION);
        $TBL_QUESTIONS = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $em = Database::getManager();
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_exercises is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $TBL_QUESTION_OPTIONS is not named in camelCase.
Open

    public function duplicate($courseInfo = [])
    {
        $courseInfo = empty($courseInfo) ? $this->course : $courseInfo;

        if (empty($courseInfo)) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $quiz_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $row_max is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $question_id is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method get_question_type_name is not named in camelCase.
Open

    public function get_question_type_name()
    {
        $key = self::$questionTypes[$this->type];

        return get_lang($key[1]);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method prepare_course_media_select is not named in camelCase.
Open

    public static function prepare_course_media_select($course_id)
    {
        $medias = self::get_course_medias($course_id);
        $media_list = [];
        $media_list[0] = get_lang('Not linked to media');
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method return_header is not named in camelCase.
Open

    public function return_header(Exercise $exercise, $counter = null, $score = [])
    {
        $counterLabel = '';
        if (!empty($counter)) {
            $counterLabel = (int) $counter;
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method create_question is not named in camelCase.
Open

    public function create_question(
        $quiz_id,
        $question_name,
        $question_description = '',
        $max_score = 0,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_question_type is not named in camelCase.
Open

    public static function get_question_type($type)
    {
        if (ORAL_EXPRESSION == $type && 'true' !== api_get_setting('enable_record_audio')) {
            return null;
        }
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method search_engine_edit is not named in camelCase.
Open

    public function search_engine_edit(
        $exerciseId,
        $addQs = false,
        $rmQs = false
    ) {
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_default_levels is not named in camelCase.
Open

    public static function get_default_levels()
    {
        return [
            1 => 1,
            2 => 2,
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_count_course_medias is not named in camelCase.
Open

    public static function get_count_course_medias($course_id)
    {
        $table_question = Database::get_course_table(TABLE_QUIZ_QUESTION);
        $result = Database::select(
            'count(*) as count',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_course_medias is not named in camelCase.
Open

    public static function get_course_medias(
        $course_id,
        $start = 0,
        $limit = 100,
        $sidx = 'question',
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method show_media_content is not named in camelCase.
Open

    public function show_media_content()
    {
        $html = '';
        if (0 != $this->parent_id) {
            $parent_question = self::read($this->parent_id);
Severity: Minor
Found in public/main/exercise/question.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status