Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
public/main/gradebook/lib/fe/evalform.class.php

Summary

Maintainability
A
0 mins
Test Coverage

The method build_basic_form() has an NPath complexity of 720. The configured NPath complexity threshold is 200.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using undefined variables such as '$cats_added' which will lead to PHP notices.
Open

                                $cats_added[] = $my_cat->get_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$evaluation_object' which will lead to PHP notices.
Open

            'hid_user_id' => $evaluation_object->user_id ?? 0,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$cats_added' which will lead to PHP notices.
Open

                                $cats_added[] = $my_cat->get_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$defaults' which will lead to PHP notices.
Open

                $this->setDefaults($defaults);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$defaults' which will lead to PHP notices.
Open

                $defaults['max'] = $item['max'];
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$defaults' which will lead to PHP notices.
Open

                $defaults['max'] = $item['max'];
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$defaults' which will lead to PHP notices.
Open

                $defaults['max'] = isset($default_max) ? $default_max : 100;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$defaults' which will lead to PHP notices.
Open

                $this->setDefaults($defaults);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$defaults' which will lead to PHP notices.
Open

                $this->setDefaults($defaults);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

The method build_all_results_edit_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $questionWeighting = $this->evaluation_object->get_max();
                $select = $this->addSelect(
                    'score['.$result->get_id().']',
                    get_lang('Score'),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_result_add_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $user_info = '<td align="left" >'.$user[2].'</td>';
                $user_info .= '<td align="left" >'.$user[3].'</td>';
            }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_editing_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $cat = Category::load($parent_cat[0]->get_parent_id());
            $global_weight = $cat[0]->get_weight();
            $weight_mask = $global_weight * $this->evaluation_object->get_weight() / $parent_cat[0]->get_weight();
        }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_add_user_to_eval uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $select->addOption($letter, $letter);
            }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_all_results_edit_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $user_info = '<td align="left" >'.$user['lastname'].'</td>';
                $user_info .= '<td align="left" >'.$user['firstname'].'</td>';
            }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $select_gradebook = $this->addSelect(
                'hid_category_id',
                get_lang('Select assessment'),
                [],
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $this->addText(
                        'max',
                        [get_lang('Maximum score'), get_lang('Cannot change the score')],
                        false,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (empty($model)) {
                $this->addText(
                    'max',
                    get_lang('Maximum score'),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method sort_by_user uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $result = api_strcmp($user1['lastname'], $user2['lastname']);
            if (0 == $result) {
                return api_strcmp($user1['firstname'], $user2['firstname']);
            }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_add_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->addElement('checkbox', 'addresult', null, get_lang('Grade learners'));
        }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $class = '';
                foreach ($model['score_list'] as $item) {
                    $class = $item['css_class'];
                }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_result_add_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $renderer->setHeaderTemplate(
                '<tr>
                  <th>'.get_lang('Code').'</th>
                  <th>'.get_lang('Username').'</th>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_result_edit_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $questionWeighting = $this->evaluation_object->get_max();
            $select = $this->addSelect('score', get_lang('Score'), [], ['disable_js' => true]);

            foreach ($model['score_list'] as $item) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_all_results_edit_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $renderer->setHeaderTemplate(
                '<tr>
                  <th>'.get_lang('Code').'</th>
                  <th>'.get_lang('Username').'</th>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $class = '';
                foreach ($model['score_list'] as $item) {
                    $class = $item['css_class'];
                }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                            } else {
                                $select_gradebook->addOption($my_cat->get_name(), $my_cat->get_id());
                                $cats_added[] = $my_cat->get_id();
                            }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method build_basic_form uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                        } else {
                            $select_gradebook->addOption(get_lang('Select'), 0);
                        }
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$evaluation_object'.
Open

            'hid_user_id' => $evaluation_object->user_id ?? 0,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$extra2'.
Open

        $extra2 = null
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused local variables such as '$default_weight'.
Open

            $default_weight = 0;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The parameter $form_name is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $result_object is not named in camelCase.
Open

class EvalForm extends FormValidator
{
    const TYPE_ADD = 1;
    const TYPE_EDIT = 2;
    const TYPE_MOVE = 3;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $form_type is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $evaluation_object is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $result_object is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $evaluation_object is not named in camelCase.
Open

class EvalForm extends FormValidator
{
    const TYPE_ADD = 1;
    const TYPE_EDIT = 2;
    const TYPE_MOVE = 3;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Method name "EvalForm::build_add_user_to_eval" is not in camel caps format
Open

    protected function build_add_user_to_eval()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                  '.$user_info.'
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                'hid_course_id' => $this->evaluation_object->getCourseId(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "parent_cat" is not in valid camel caps format
Open

        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'name' => $this->evaluation_object->get_name(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        foreach ($this->evaluation_object->get_not_subscribed_students() as $user) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info .= '<td align="left" >'.$user['lastname'].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info .= '<td align="left" >'.$user[2].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

        $userInfo = api_get_user_info($this->result_object->get_user_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                $this->evaluation_object->get_max()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $parent_cat = Category::load($this->evaluation_object->get_category_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            $weight_mask = $this->evaluation_object->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "weight_mask" is not in valid camel caps format
Open

            $weight_mask = $global_weight * $this->evaluation_object->get_weight() / $parent_cat[0]->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "all_categories" is not in valid camel caps format
Open

        $all_categories = Category:: load(
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "cat_id" is not in valid camel caps format
Open

            $this->addElement('hidden', 'hid_category_id', $cat_id);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "select_gradebook" is not in valid camel caps format
Open

                                $select_gradebook->addOption($my_cat->get_name(), $my_cat->get_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "cats_added" is not in valid camel caps format
Open

                                $cats_added[] = $my_cat->get_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                                $cats_added[] = $my_cat->get_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Expected 30 spaces after parameter type; 5 found
Open

     * @param string     $method
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

            $this->result_object = $result_object;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Missing function doc comment
Open

    public function display()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

        foreach ($this->result_object as $result) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_and_user" is not in valid camel caps format
Open

        foreach ($results_and_users as $result_and_user) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info = '<td align="left" >'.$user[2].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "global_weight" is not in valid camel caps format
Open

            $weight_mask = $global_weight * $this->evaluation_object->get_weight() / $parent_cat[0]->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'hid_category_id' => $this->evaluation_object->get_category_id(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "cat_id" is not in valid camel caps format
Open

        $cat_id = $this->evaluation_object->get_category_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "select_gradebook" is not in valid camel caps format
Open

            $select_gradebook = $this->addSelect(
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "all_categories" is not in valid camel caps format
Open

            if (!empty($all_categories)) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "grade_model_id" is not in valid camel caps format
Open

                        if (empty($grade_model_id)) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            $this->evaluation_object = $evaluation_object;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "results_and_users" is not in valid camel caps format
Open

        foreach ($results_and_users as $result_and_user) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

              '.$user_info.'
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "element_name" is not in valid camel caps format
Open

                $element_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "element_name" is not in valid camel caps format
Open

            $renderer->setElementTemplate($template, $element_name);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "template_submit" is not in valid camel caps format
Open

        $template_submit = '<tr>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "weight_mask" is not in valid camel caps format
Open

            $weight_mask = $this->evaluation_object->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "grade_model_id" is not in valid camel caps format
Open

                        $grade_model_id = $my_cat->get_grade_model_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "default_weight" is not in valid camel caps format
Open

                                $default_weight = $my_cat->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::sort_by_user" is not in camel caps format
Open

    public function sort_by_user($item1, $item2)
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_all_results_edit_form" is not in camel caps format
Open

    protected function build_all_results_edit_form()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_template" is not in valid camel caps format
Open

        $renderer->setFormTemplate($form_template);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

               <td align="left">{element} / '.$this->evaluation_object->get_max().'
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                'hid_category_id' => $this->evaluation_object->get_category_id(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            $weight_mask = $global_weight * $this->evaluation_object->get_weight() / $parent_cat[0]->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'max' => $this->evaluation_object->get_max(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_basic_form" is not in camel caps format
Open

    private function build_basic_form($edit = 0)
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "all_categories" is not in valid camel caps format
Open

        if (1 == count($all_categories)) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "all_categories" is not in valid camel caps format
Open

                foreach ($all_categories as $my_cat) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                    if ($my_cat->getCourseId() == api_get_course_int_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                        $grade_model_id = $my_cat->get_grade_model_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "select_gradebook" is not in valid camel caps format
Open

                            $select_gradebook->addOption(get_lang('Select'), 0);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_type" is not in valid camel caps format
Open

        $form_type,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        if (isset($evaluation_object)) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info .= '<td align="left" >'.$user['firstname'].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                    $this->evaluation_object->get_max()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $this->addElement('hidden', 'maxvalue', $this->evaluation_object->get_max());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "nr_users" is not in valid camel caps format
Open

        $this->addElement('hidden', 'nr_users', $nr_users);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                                $select_gradebook->addOption($my_cat->get_name(), $my_cat->get_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                        if ($this->evaluation_object->get_category_id() == $my_cat->get_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

        if (isset($result_object)) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_and_user" is not in valid camel caps format
Open

            $result = $result_and_user['result'];
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

        $this->addElement('hidden', 'evaluation_id', $this->result_object->get_evaluation_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

                    'score' => $this->result_object->get_score(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                    'maximum' => $this->evaluation_object->get_max(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_add_form" is not in camel caps format
Open

    protected function build_add_form()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'hid_course_id' => $this->evaluation_object->getCourseId(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_title" is not in valid camel caps format
Open

            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "default_weight" is not in valid camel caps format
Open

            $default_weight = 0;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                                $cats_added[] = $my_cat->get_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Expected 30 spaces after parameter type; 5 found
Open

     * @param string     $action
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "results_and_users" is not in valid camel caps format
Open

        $results_and_users = [];
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                $this->evaluation_object->get_max()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

               <td align="left">{element} / '.$this->evaluation_object->get_max().'
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "parent_cat" is not in valid camel caps format
Open

            $weight_mask = $global_weight * $this->evaluation_object->get_weight() / $parent_cat[0]->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "weight_mask" is not in valid camel caps format
Open

        $weight = $weight_mask = $this->evaluation_object->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_id" is not in valid camel caps format
Open

            'hid_user_id' => $evaluation_object->user_id ?? 0,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'created_at' => api_get_utc_datetime($this->evaluation_object->get_date()),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'visible' => $this->evaluation_object->is_visible(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $cat_id = $this->evaluation_object->get_category_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "session_id" is not in valid camel caps format
Open

        $session_id = api_get_session_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "session_id" is not in valid camel caps format
Open

            $session_id,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_type" is not in valid camel caps format
Open

        switch ($form_type) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "parent_cat" is not in valid camel caps format
Open

            $cat = Category::load($parent_cat[0]->get_parent_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "id_current" is not in valid camel caps format
Open

        $this->addElement('hidden', 'hid_id', $id_current);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_title" is not in valid camel caps format
Open

        $form_title = get_lang('Add classroom activity');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                                $select_gradebook->addOption($my_cat->get_name(), $my_cat->get_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                'hid_course_code' => $this->evaluation_object->get_course_code(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'hid_user_id' => $evaluation_object->user_id ?? 0,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $evaluation_object,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "all_categories" is not in valid camel caps format
Open

                ' [0 .. <span id="max_weight">'.$all_categories[0]->get_weight().'</span>] ',
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "parent_cat" is not in valid camel caps format
Open

        $parent_cat = Category::load($this->evaluation_object->get_category_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "global_weight" is not in valid camel caps format
Open

            $global_weight = $cat[0]->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "opendocurl_end" is not in valid camel caps format
Open

        return $opendocurl_start.api_get_person_name($firstname, $lastname).' ('.$username.')'.$opendocurl_end;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'hid_id' => $this->evaluation_object->get_id(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'description' => $this->evaluation_object->get_description(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "weight_mask" is not in valid camel caps format
Open

            'weight_mask' => $weight_mask,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "cats_added" is not in valid camel caps format
Open

                                $cats_added[] = $my_cat->get_id();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "opendocurl_start" is not in valid camel caps format
Open

        $opendocurl_start = '';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "opendocurl_start" is not in valid camel caps format
Open

                $opendocurl_start .= '<a href="'.$doc_url.'" target="_blank">';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "visibility_default" is not in valid camel caps format
Open

            $visibility_default = 0;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            $link = LinkFactory::get_evaluation_link($this->evaluation_object->get_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "default_weight" is not in valid camel caps format
Open

                            $default_weight = $my_cat->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "visibility_default" is not in valid camel caps format
Open

        $visibility_default = 1;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_name" is not in valid camel caps format
Open

        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

            $this->result_object = $result_object;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "results_and_users" is not in valid camel caps format
Open

        usort($results_and_users, ['EvalForm', 'sort_by_user']);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        foreach ($this->evaluation_object->get_target_categories() as $cat) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_result_add_form" is not in camel caps format
Open

    protected function build_result_add_form(): void
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $users = GradebookUtils::get_users_in_course($this->evaluation_object->getCourseId());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_result_edit_form" is not in camel caps format
Open

    protected function build_result_edit_form()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_editing_form" is not in camel caps format
Open

    protected function build_editing_form()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $weight = $weight_mask = $this->evaluation_object->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                                $default_weight = $my_cat->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "select_gradebook" is not in valid camel caps format
Open

                                $select_gradebook->addOption(get_lang('Default'), $my_cat->get_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                                $select_gradebook->addOption(get_lang('Default'), $my_cat->get_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "doc_url" is not in valid camel caps format
Open

                $opendocurl_start .= '<a href="'.$doc_url.'" target="_blank">';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

        $result_object,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Missing function doc comment
Open

    public function sort_by_user($item1, $item2)
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "results_and_users" is not in valid camel caps format
Open

            $results_and_users[] = ['result' => $result, 'user' => $user];
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_and_user" is not in valid camel caps format
Open

            $user = $result_and_user['user'];
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "template_submit" is not in valid camel caps format
Open

        $renderer->setElementTemplate($template_submit, 'submit');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        $this->addElement('static', null, null, '"'.$this->evaluation_object->get_name().'" ');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info = '<td align="left" >'.$user[3].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

              '.$user_info.'
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

        $this->addElement('hidden', 'hid_user_id', $this->result_object->get_user_id());
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                'hid_user_id' => $this->evaluation_object->get_user_id(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "opendocurl_start" is not in valid camel caps format
Open

        return $opendocurl_start.api_get_person_name($firstname, $lastname).' ('.$username.')'.$opendocurl_end;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        if ($this->evaluation_object->get_category_id() < 0) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Expected 30 spaces after parameter type; 5 found
Open

     * @param string     $form_name
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            $this->evaluation_object = $evaluation_object;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_template" is not in valid camel caps format
Open

        $form_template = '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_move_form" is not in camel caps format
Open

    protected function build_move_form()
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "element_name" is not in valid camel caps format
Open

            $element_name = 'score['.$user[0].']';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "nr_users" is not in valid camel caps format
Open

            $nr_users++;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "template_submit" is not in valid camel caps format
Open

        $renderer->setElementTemplate($template_submit, 'submit');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "opendocurl_end" is not in valid camel caps format
Open

                $opendocurl_end = '</a>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                            $default_weight = $my_cat->get_weight();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "doc_url" is not in valid camel caps format
Open

            if (null != $doc_url) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_name" is not in valid camel caps format
Open

        parent::__construct($form_name, $method, $action);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

        if (null == $this->evaluation_object->getCourseId()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "id_current" is not in valid camel caps format
Open

        $id_current = isset($this->id) ? $this->id : null;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                foreach ($all_categories as $my_cat) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                            if (0 == $my_cat->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "default_max" is not in valid camel caps format
Open

                $defaults['max'] = isset($default_max) ? $default_max : 100;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "default_max" is not in valid camel caps format
Open

                $default_max = api_get_setting('gradebook_default_weight');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "opendocurl_end" is not in valid camel caps format
Open

        $opendocurl_end = '';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                if (!$this->evaluation_object->has_results()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "visibility_default" is not in valid camel caps format
Open

        $this->setDefaults(['visible' => $visibility_default]);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Method name "EvalForm::build_stud_label" is not in camel caps format
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Expected 33 spaces after parameter type; 8 found
Open

     * @param int        $form_type         1=add, 2=edit,3=move,4=result_add
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Expected 26 spaces after parameter type; 1 found
Open

     * @param Evaluation $evaluation_object the category object
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Missing parameter name
Open

     * @param            $result_object     the result object
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Missing function doc comment
Open

    public function setDefaults($defaultValues = [], $filter = null)
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "template_submit" is not in valid camel caps format
Open

        $template_submit = '<tr>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info = '<td align="left" >'.$user['firstname'].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info = '<td align="left" >'.$user['lastname'].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                $questionWeighting = $this->evaluation_object->get_max();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "nr_users" is not in valid camel caps format
Open

        $nr_users = 0;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "user_info" is not in valid camel caps format
Open

                $user_info .= '<td align="left" >'.$user[3].'</td>';
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

                    '/ '.$this->evaluation_object->get_max(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            $questionWeighting = $this->evaluation_object->get_max();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "result_object" is not in valid camel caps format
Open

                if ($this->result_object->get_score() == $i) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "evaluation_object" is not in valid camel caps format
Open

            'hid_course_code' => $this->evaluation_object->get_course_code(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "form_title" is not in valid camel caps format
Open

        $this->addHeader($form_title);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "my_cat" is not in valid camel caps format
Open

                        if ($this->evaluation_object->get_category_id() == $my_cat->get_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "default_max" is not in valid camel caps format
Open

                $defaults['max'] = isset($default_max) ? $default_max : 100;
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

Variable "doc_url" is not in valid camel caps format
Open

            $doc_url = $link->get_view_url($id);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpcodesniffer

The variable $id_current is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_weight is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $select_gradebook is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cats_added is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $global_weight is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_categories is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $session_id is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $grade_model_id is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $result_object is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $evaluation_object is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $id_current is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_cat is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $global_weight is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_max is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $visibility_default is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_template is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $results_and_users is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $results_and_users is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_cat is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $select_gradebook is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $opendocurl_end is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_weight is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $opendocurl_start is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $evaluation_object is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_template is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $results_and_users is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $select_gradebook is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $nr_users is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_cat is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $weight_mask is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $weight_mask is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $evaluation_object is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $template_submit is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $template_submit is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cat_id is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_max is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $template_submit is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $element_name is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $element_name is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cat_id is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_categories is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $opendocurl_start is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_name is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $results_and_users is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $weight_mask is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_title is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_categories is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $visibility_default is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $doc_url is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parent_cat is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $weight_mask is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $grade_model_id is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $select_gradebook is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_weight is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $doc_url is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $result_and_user is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $template_submit is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_categories is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $all_categories is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $my_cat is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $user_info is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $element_name is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $default_max is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $doc_url is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_type is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $result_and_user is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $result_and_user is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $nr_users is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $nr_users is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $result_object is not named in camelCase.
Open

    public function __construct(
        $form_type,
        $evaluation_object,
        $result_object,
        $form_name,
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_title is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $form_title is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $session_id is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $cats_added is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $visibility_default is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $opendocurl_end is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $opendocurl_start is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $opendocurl_end is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method build_result_add_form is not named in camelCase.
Open

    protected function build_result_add_form(): void
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setFormTemplate(
            '<form{attributes}>
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_move_form is not named in camelCase.
Open

    protected function build_move_form()
    {
        $renderer = &$this->defaultRenderer();
        $renderer->setCustomElementTemplate('<span>{element}</span> ');
        $this->addElement('static', null, null, '"'.$this->evaluation_object->get_name().'" ');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_all_results_edit_form is not named in camelCase.
Open

    protected function build_all_results_edit_form()
    {
        //extra field for check on maxvalue
        $this->addElement('header', get_lang('Grade learners'));
        $renderer = &$this->defaultRenderer();
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_result_edit_form is not named in camelCase.
Open

    protected function build_result_edit_form()
    {
        $userInfo = api_get_user_info($this->result_object->get_user_id());
        $this->addHeader(get_lang('User').': '.$userInfo['complete_name']);
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_basic_form is not named in camelCase.
Open

    private function build_basic_form($edit = 0)
    {
        $form_title = get_lang('Add classroom activity');
        if (!empty($_GET['editeval']) && 1 == $_GET['editeval']) {
            $form_title = get_lang('Edit evaluation');
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_add_form is not named in camelCase.
Open

    protected function build_add_form()
    {
        $this->setDefaults(
            [
                'hid_user_id' => $this->evaluation_object->get_user_id(),
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_add_user_to_eval is not named in camelCase.
Open

    protected function build_add_user_to_eval()
    {
        $this->addHeader(get_lang('Choose users for this evaluation'));
        $select = $this->addSelect(
            'firstLetterUser',
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_editing_form is not named in camelCase.
Open

    protected function build_editing_form()
    {
        $parent_cat = Category::load($this->evaluation_object->get_category_id());
        //@TODO $weight_mask is replaced?
        if (0 == $parent_cat[0]->get_parent_id()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method build_stud_label is not named in camelCase.
Open

    private function build_stud_label($id, $username, $lastname, $firstname)
    {
        $opendocurl_start = '';
        $opendocurl_end = '';
        // evaluation's origin is a link
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method sort_by_user is not named in camelCase.
Open

    public function sort_by_user($item1, $item2)
    {
        $user1 = $item1['user'];
        $user2 = $item2['user'];
        if (api_sort_by_first_name()) {
Severity: Minor
Found in public/main/gradebook/lib/fe/evalform.class.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status