public/main/inc/lib/NotificationEvent.php
The method getNotificationsByUser() has an NPath complexity of 250. The configured NPath complexity threshold is 200. Open
Open
public function getNotificationsByUser($userId)
{
$userInfo = api_get_user_info($userId);
$events = $this->get_all();
$extraFieldData = $this->getUserExtraData(api_get_user_id());- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
Missing class import via use statement (line '294', column '25'). Open
Open
$interval = new DateInterval('P'.$dayDiff.'D');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method markAsRead uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$data = [];
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Expected 9 spaces after parameter type; 1 found Open
Open
* @param array $data- Exclude checks
You must use "/**" style comments for a class comment Open
Open
class NotificationEvent extends Model- Exclude checks
Missing function doc comment Open
Open
public function eventTypeToString($eventTypeId)- Exclude checks
Expected 4 spaces after parameter type; 1 found Open
Open
* @param int $dayDiff- Exclude checks
Missing function doc comment Open
Open
public function getEventsForSelect()- Exclude checks
Missing function doc comment Open
Open
public function getNotificationsByUser($userId)- Exclude checks