chamilo/chamilo-lms

View on GitHub
public/main/inc/lib/SkillRelProfileModel.php

Summary

Maintainability
A
0 mins
Test Coverage

Variable "skill_data" is not in valid camel caps format
Open

            foreach ($skills as $skill_data) {

You must use "/**" style comments for a class comment
Open

class SkillRelProfileModel extends Model

Variable "skill_data" is not in valid camel caps format
Open

                $return[] = $skill_data['skill_id'];

The variable $skill_data is not named in camelCase.
Open

    public function getSkillsByProfile($profileId)
    {
        $profileId = (int) $profileId;
        $skills = $this->get_all(['where' => ['profile_id = ? ' => $profileId]]);
        $return = [];

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $skill_data is not named in camelCase.
Open

    public function getSkillsByProfile($profileId)
    {
        $profileId = (int) $profileId;
        $skills = $this->get_all(['where' => ['profile_id = ? ' => $profileId]]);
        $return = [];

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status