public/main/inc/lib/access_url_edit_courses_to_url_functions.lib.php
Missing class import via use statement (line '33', column '31'). Open
Open
$xajax_response = new xajaxResponse();- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method search_courses uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$return .= '...<br />';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$id'. Open
Open
public function search_courses($needle, $id)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Variable "xajax_response" is not in valid camel caps format Open
Open
$xajax_response->addAssign(- Exclude checks
Variable "tbl_course" is not in valid camel caps format Open
Open
$sql = 'SELECT code, title FROM '.$tbl_course.' u '.- Exclude checks
Variable "tbl_course" is not in valid camel caps format Open
Open
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);- Exclude checks
Missing parameter name Open
Open
* @param int Deprecated param- Exclude checks
Variable "xajax_response" is not in valid camel caps format Open
Open
$xajax_response = new xajaxResponse();- Exclude checks
Variable "xajax_response" is not in valid camel caps format Open
Open
return $xajax_response;- Exclude checks
Missing parameter name Open
Open
* @param string String to search for- Exclude checks
Method name "Accessurleditcoursestourl::search_courses" is not in camel caps format Open
Open
public function search_courses($needle, $id)- Exclude checks
The variable $xajax_response is not named in camelCase. Open
Open
public function search_courses($needle, $id)
{
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
$xajax_response = new xajaxResponse();
$return = '';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $xajax_response is not named in camelCase. Open
Open
public function search_courses($needle, $id)
{
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
$xajax_response = new xajaxResponse();
$return = '';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $xajax_response is not named in camelCase. Open
Open
public function search_courses($needle, $id)
{
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
$xajax_response = new xajaxResponse();
$return = '';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $tbl_course is not named in camelCase. Open
Open
public function search_courses($needle, $id)
{
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
$xajax_response = new xajaxResponse();
$return = '';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $tbl_course is not named in camelCase. Open
Open
public function search_courses($needle, $id)
{
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
$xajax_response = new xajaxResponse();
$return = '';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method search_courses is not named in camelCase. Open
Open
public function search_courses($needle, $id)
{
$tbl_course = Database::get_main_table(TABLE_MAIN_COURSE);
$xajax_response = new xajaxResponse();
$return = '';- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}