Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star
public/main/inc/lib/exercise_show_functions.lib.php

Summary

Maintainability
A
0 mins
Test Coverage

The method display_calculated_answer has 10 parameters. Consider reducing the number of parameters to less than 10.
Open

    public static function display_calculated_answer(
        $exercise,
        $feedback_type,
        $answer,
        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

The method display_multiple_answer_true_false() has an NPath complexity of 8064. The configured NPath complexity threshold is 200.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method display_multiple_answer_combination_true_false() has an NPath complexity of 3840. The configured NPath complexity threshold is 200.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method display_multiple_answer_true_false has 12 parameters. Consider reducing the number of parameters to less than 10.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

The method displayMultipleAnswerTrueFalseDegreeCertainty() has an NPath complexity of 6144. The configured NPath complexity threshold is 200.
Open

    public static function displayMultipleAnswerTrueFalseDegreeCertainty(
        $exercise,
        $feedbackType,
        $studentChoice,
        $studentChoiceDegree,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method display_unique_or_multiple_answer has 13 parameters. Consider reducing the number of parameters to less than 10.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

The method display_unique_or_multiple_answer() has an NPath complexity of 1026432. The configured NPath complexity threshold is 200.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method display_hotspot_answer() has an NPath complexity of 440. The configured NPath complexity threshold is 200.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method display_multiple_answer_combination_true_false has 12 parameters. Consider reducing the number of parameters to less than 10.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

Missing class import via use statement (line '787', column '29').
Open

            $question = new MultipleAnswerCombinationTrueFalse();
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '657', column '25').
Open

        $question = new MultipleAnswerTrueFalseDegreeCertainty();
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method display_fill_in_blanks_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            echo '<tr><td>';
            echo Security::remove_XSS($answerHTML, COURSEMANAGERLOWSECURITY);
            echo '</td>';
            echo '</tr>';
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if ($studentChoice) {
                $icon = StateIcon::CHECKBOX_MARKED;
            } else {
                $icon = StateIcon::CHECKBOX_BLANK;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method displayMultipleAnswerTrueFalseDegreeCertainty uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '-';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_free_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<tr>';
                echo Display::tag('td', ExerciseLib::getNotCorrectedYetText());
                echo '</tr>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_hotspot_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $content .= '&nbsp;';
                }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $icon = StateIcon::RADIOBOX_BLANK;
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_multiple_answer_true_false uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $content .= '-';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<td>&nbsp;</td>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method displayMultipleAnswerTrueFalseDegreeCertainty uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    echo '-';
                }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_calculated_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if (empty($id)) {
                echo '<tr><td>'.Security::remove_XSS($answer).'</td></tr>';
            } else {
                echo '<tr><td>';
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_hotspot_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $content .= '&nbsp;';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            if ($answerCorrect) {
                $iconAnswer = StateIcon::CHECKBOX_MARKED;
            } else {
                $iconAnswer = StateIcon::CHECKBOX_BLANK;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_calculated_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<tr><td>';
                echo Security::remove_XSS($answer);
                echo '</tr>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_hotspot_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $content .= '<td class="text-left" width="60%">&nbsp;</td>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $icon = StateIcon::CHECKBOX_BLANK;
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method displayMultipleAnswerTrueFalseDegreeCertainty uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            echo '-';
        }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_multiple_answer_combination_true_false uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo $question->options[2];
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_multiple_answer_combination_true_false uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<td>&nbsp;</td>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_multiple_answer_true_false uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    $content .= '-';
                }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method displayMultipleAnswerTrueFalseDegreeCertainty uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<td>&nbsp;</td>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_multiple_answer_combination_true_false uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    echo $question->options[2];
                }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_calculated_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<tr><td>';
                echo Security::remove_XSS($answer);
                echo '</td><td>';
                echo Security::remove_XSS($choice);
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $iconAnswer = StateIcon::RADIOBOX_BLANK;
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $iconAnswer = StateIcon::CHECKBOX_BLANK;
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method display_unique_or_multiple_answer uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                echo '<td style="width:5%">';
                echo '-';
                echo '</td>';
            }
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$exercise'.
Open

        $exercise,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$questionId'.
Open

        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$originalStudentAnswer'.
Open

        $originalStudentAnswer = ''
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$resultsDisabled'.
Open

        $resultsDisabled = 0,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$answerType'.
Open

        $answerType,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$id'.
Open

        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$ans'.
Open

        $ans,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$answerType'.
Open

        $answerType,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$ans'.
Open

        $ans,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$questionId'.
Open

        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$id'.
Open

        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$questionId'.
Open

        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$resultsDisabled'.
Open

        $resultsDisabled,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused local variables such as '$course_id'.
Open

            $course_id = api_get_course_int_id();
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused parameters such as '$resultsDisabled'.
Open

        $resultsDisabled = 0
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$id'.
Open

        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$showTotalScoreAndUserChoices'.
Open

        $showTotalScoreAndUserChoices,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$questionId'.
Open

        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$resultsDisabled'.
Open

        $resultsDisabled = 0
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$feedback_type'.
Open

        $feedback_type,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$ans'.
Open

        $ans,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The parameter $feedback_type is not named in camelCase.
Open

    public static function display_calculated_answer(
        $exercise,
        $feedback_type,
        $answer,
        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $feedback_type is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $feedback_type is not named in camelCase.
Open

    public static function display_free_answer(
        $feedback_type,
        $answer,
        $exe_id,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $feedback_type is not named in camelCase.
Open

    public static function display_oral_expression_answer(
        $feedback_type,
        $answer,
        $trackExerciseId,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $exe_id is not named in camelCase.
Open

    public static function display_free_answer(
        $feedback_type,
        $answer,
        $exe_id,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Method name "ExerciseShowFunctions::display_calculated_answer" is not in camel caps format
Open

    public static function display_calculated_answer(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param string    Answer text
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 12 spaces but found 24
Open

                        $questionId
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $studentChoice does not match actual variable name $answer
Open

     * @param string $studentChoice
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                if ($hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 39 spaces after parameter type; 1 found
Open

     * @param Exercise $exercise
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int       Question ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "exe_id" is not in valid camel caps format
Open

        $exe_id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_hotspot_answer" is not in camel caps format
Open

    public static function display_hotspot_answer(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

            if (false === $hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 17 spaces after parameter name; 1 found
Open

     * @param int $feedbackType Feedback type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 3 spaces after parameter type; 2 found
Open

     * @param string  $answerCorrect Correct answer comment
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 6 spaces after parameter type; 1 found
Open

     * @param int $resultsDisabled
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 5 spaces after parameter type; 1 found
Open

     * @param bool $showTotalScoreAndUserChoices
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "course_id" is not in valid camel caps format
Open

            $course_id = api_get_course_int_id();
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

            if (isset($new_options[$studentChoice])) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int       Exercise ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param $trackExerciseId
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 13 spaces after parameter type; 1 found
Open

     * @param int $resultsDisabled
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

        if ($showAlertIfNotCorrected && !$questionScore && EXERCISE_FEEDBACK_TYPE_EXAM != $feedback_type && empty($comment) && empty($teacherAudio)) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $answer does not match actual variable name $answerId
Open

     * @param string $answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 3 spaces after parameter type; 2 found
Open

     * @param string  $answer Textual answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_multiple_answer_true_false" is not in camel caps format
Open

    public static function display_multiple_answer_true_false(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

            if (!$hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int Student choice
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param string  Textual answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

        if (EXERCISE_FEEDBACK_TYPE_EXAM != $feedback_type) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param $feedback_type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $orderColor does not match actual variable name $resultsDisabled
Open

     * @param int    $orderColor
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Blank line found at end of control structure
Open
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 19 spaces after parameter name; 1 found
Open

     * @param int $answerType Answer type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 6 spaces after parameter type; 1 found
Open

     * @param int $studentChoice Student choice
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 6 spaces after parameter type; 1 found
Open

     * @param int $id Exercise ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

                    $content .= get_lang($new_options[$answerCorrect]['title']);
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

            if (!$hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 3 spaces after parameter type; 2 found
Open

     * @param string  $answerComment Comment on answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 6 spaces after parameter type; 1 found
Open

     * @param int $questionId Question ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 19 spaces after parameter name; 1 found
Open

     * @param int $questionId Question ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int Exercise ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 16 spaces but found 20
Open

                    )
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing class doc comment
Open

class ExerciseShowFunctions
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 16 spaces after parameter name; 1 found
Open

     * @param int $studentChoice Student choice
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

        $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

            $new_options = [];
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

                if (isset($new_options[$answerCorrect])) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_multiple_answer_combination_true_false" is not in camel caps format
Open

    public static function display_multiple_answer_combination_true_false(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

        $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param bool Whether to show the answer comment or not
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 16
Open

                RESULT_DISABLE_SHOW_ONLY_IN_CORRECT_ANSWER,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int       Exercise ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

        $feedback_type,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 13 spaces after parameter type; 1 found
Open

     * @param int $questionScore
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $feedback_type does not match actual variable name $exercise
Open

     * @param int    $feedback_type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 16 spaces after parameter name; 1 found
Open

     * @param string  $answerComment Comment on answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 5 spaces after parameter type; 1 found
Open

     * @param bool $ans Whether to show the answer comment or not
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

                if (isset($new_options[$studentChoice]) || in_array(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_fill_in_blanks_answer" is not in camel caps format
Open

    public static function display_fill_in_blanks_answer(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

        $feedback_type,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param $answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param $questionId
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $answerComment does not match actual variable name $studentChoice
Open

     * @param string $answerComment
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

                if (0 == $feedback_type) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 8 spaces but found 20
Open

                    );
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

        $feedback_type,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

        if (!$hide_expected_answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 16 spaces after parameter name; 1 found
Open

     * @param string  $answerCorrect Correct answer comment
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 27 spaces after parameter name; 1 found
Open

     * @param int $id Exercise ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param string  Comment on answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $showTotalScoreAndUserChoices does not match actual variable name $orderColor
Open

     * @param bool   $showTotalScoreAndUserChoices
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

            if (EXERCISE_FEEDBACK_TYPE_EXAM != $feedback_type) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 6 spaces after parameter type; 1 found
Open

     * @param int $feedbackType Feedback type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

            if (isset($new_options[$studentChoice])) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int Answer type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int Question ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    if ($hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 14 spaces after parameter type; 1 found
Open

     *  @param Exercise $exercise
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "exe_id" is not in valid camel caps format
Open

        $comments = Event::get_comments($exe_id, $questionId);
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $resultsDisabled does not match actual variable name $answerComment
Open

     * @param int    $resultsDisabled
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 24
Open

                        [
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_oral_expression_answer" is not in camel caps format
Open

    public static function display_oral_expression_answer(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_unique_or_multiple_answer" is not in camel caps format
Open

    public static function display_unique_or_multiple_answer(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 23 spaces after parameter name; 1 found
Open

     * @param string  $answer Textual answer
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

                    $new_options[$item['iid']] = $item;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Method name "ExerciseShowFunctions::display_free_answer" is not in camel caps format
Open

    public static function display_free_answer(
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 12 spaces but found 24
Open

                        $trackExerciseId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

        $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 6 spaces after parameter type; 1 found
Open

     * @param int $answerType Answer type
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Expected 26 spaces after parameter name; 1 found
Open

     * @param bool $ans Whether to show the answer comment or not
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "results_disabled" is not in valid camel caps format
Open

                    $exercise->results_disabled,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param string  Correct answer comment
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param string    Answer text
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

        $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 16
Open

                RESULT_DISABLE_SHOW_SCORE_AND_EXPECTED_ANSWERS_AND_RANKING,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 24
Open

                        $resultsDisabled,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Missing parameter name
Open

     * @param int       Question ID
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "feedback_type" is not in valid camel caps format
Open

        $feedback_type,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Doc comment for parameter $answerId does not match actual variable name $feedback_type
Open

     * @param int    $answerId
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    $hide_expected_answer = false;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "new_options" is not in valid camel caps format
Open

                $content .= get_lang($new_options[$studentChoice]['title']);
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                    if ($hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

                $hide_expected_answer = true;
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Variable "hide_expected_answer" is not in valid camel caps format
Open

            if (!$hide_expected_answer) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 12 spaces but found 24
Open

                        $questionId
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            ) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 24
Open

                        [
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Line indented incorrectly; expected at least 16 spaces, found 12
Open

            ) {
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 24
Open

                        $resultsDisabled,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 12 spaces but found 24
Open

                        $trackExerciseId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 8 spaces but found 20
Open

                    );
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 16
Open

                RESULT_DISABLE_SHOW_ONLY_IN_CORRECT_ANSWER,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 16 spaces but found 20
Open

                    )
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

Multi-line function call not indented correctly; expected 20 spaces but found 16
Open

                RESULT_DISABLE_SHOW_SCORE_AND_EXPECTED_ANSWERS_AND_RANKING,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpcodesniffer

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $feedback_type is not named in camelCase.
Open

    public static function display_free_answer(
        $feedback_type,
        $answer,
        $exe_id,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $exe_id is not named in camelCase.
Open

    public static function display_free_answer(
        $feedback_type,
        $answer,
        $exe_id,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $feedback_type is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $feedback_type is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $feedback_type is not named in camelCase.
Open

    public static function display_oral_expression_answer(
        $feedback_type,
        $answer,
        $trackExerciseId,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $course_id is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $hide_expected_answer is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $new_options is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method display_fill_in_blanks_answer is not named in camelCase.
Open

    public static function display_fill_in_blanks_answer(
        $exercise,
        $feedbackType,
        $answer,
        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_multiple_answer_combination_true_false is not named in camelCase.
Open

    public static function display_multiple_answer_combination_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_calculated_answer is not named in camelCase.
Open

    public static function display_calculated_answer(
        $exercise,
        $feedback_type,
        $answer,
        $id,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_oral_expression_answer is not named in camelCase.
Open

    public static function display_oral_expression_answer(
        $feedback_type,
        $answer,
        $trackExerciseId,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_hotspot_answer is not named in camelCase.
Open

    public static function display_hotspot_answer(
        $exercise,
        $feedback_type,
        $answerId,
        $answer,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_unique_or_multiple_answer is not named in camelCase.
Open

    public static function display_unique_or_multiple_answer(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_free_answer is not named in camelCase.
Open

    public static function display_free_answer(
        $feedback_type,
        $answer,
        $exe_id,
        $questionId,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method display_multiple_answer_true_false is not named in camelCase.
Open

    public static function display_multiple_answer_true_false(
        $exercise,
        $feedbackType,
        $answerType,
        $studentChoice,
Severity: Minor
Found in public/main/inc/lib/exercise_show_functions.lib.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status